Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalNetwork: Gateway Server and Client controllers #2046

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Sep 25, 2023

Description

This pr implements the logic to create and enforce specific gateway resources based on the general type and a template.

How Has This Been Tested?

  • locally

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/client-and-server-controller branch from 450acf3 to c97ef75 Compare September 25, 2023 09:35
@aleoli aleoli force-pushed the aol/client-and-server-controller branch from c97ef75 to 6c8e78b Compare September 25, 2023 09:40
@aleoli
Copy link
Member Author

aleoli commented Sep 25, 2023

/build

@aleoli aleoli force-pushed the aol/client-and-server-controller branch from 6c8e78b to 3fa8a07 Compare September 25, 2023 10:10
@aleoli aleoli force-pushed the aol/client-and-server-controller branch 3 times, most recently from 05b55da to 98b97ef Compare September 25, 2023 10:30
@aleoli aleoli marked this pull request as ready for review September 25, 2023 12:28
@aleoli aleoli requested review from cheina97 and fra98 September 25, 2023 12:28
@cheina97 cheina97 force-pushed the aol/client-and-server-controller branch from 98b97ef to 7f620fc Compare September 26, 2023 09:08
@cheina97 cheina97 force-pushed the aol/client-and-server-controller branch from 7f620fc to efde70b Compare October 2, 2023 09:45
@cheina97 cheina97 force-pushed the aol/client-and-server-controller branch from efde70b to 93cd3a2 Compare October 2, 2023 09:45
@cheina97 cheina97 force-pushed the aol/client-and-server-controller branch from 93cd3a2 to 64fc43f Compare October 2, 2023 10:34
@aleoli aleoli force-pushed the aol/client-and-server-controller branch 2 times, most recently from 552c2d4 to c1e6eea Compare October 2, 2023 12:39
@aleoli aleoli force-pushed the aol/client-and-server-controller branch from c1e6eea to db9f6a4 Compare October 2, 2023 12:49
@fra98 fra98 added the hold Prevent bot merging label Oct 2, 2023
@fra98 fra98 removed the hold Prevent bot merging label Oct 2, 2023
@aleoli aleoli force-pushed the aol/client-and-server-controller branch from db9f6a4 to 1c0705a Compare October 3, 2023 09:43
@aleoli
Copy link
Member Author

aleoli commented Oct 3, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 3, 2023
@adamjensenbot adamjensenbot merged commit 3806bdf into liqotech:network-external Oct 3, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants