Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Improved MacOS compatibility #2047

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

cannarelladev
Copy link
Member

Description

In this PR I want to improve the Makefile compatibility with MacOS:

sed command in MacOS has a different behavior from the GNU one, in particular when it is used with the -i flag it needs a suffix for the name of the "backup" original file.

With this little fix it automatically selects the right sed syntax checking the running OS

@adamjensenbot
Copy link
Collaborator

Hi @cannarelladev. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cannarelladev cannarelladev changed the title Improved MacOS compatibility Makefile: Improved MacOS compatibility Sep 26, 2023
@cannarelladev cannarelladev marked this pull request as draft September 26, 2023 14:20
@cheina97
Copy link
Member

lgtm

@cheina97 cheina97 marked this pull request as ready for review September 26, 2023 14:28
@cheina97
Copy link
Member

/rebase test=true

@cheina97
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 26, 2023
@adamjensenbot adamjensenbot merged commit dc764f5 into liqotech:master Sep 26, 2023
9 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants