Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: envtest server new crds path #2048

Merged

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Sep 27, 2023

Description

This PR fixes the reference to the CRDs folder path in unit tests.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 force-pushed the frc/CrdReplicatorTestFix branch from cff824b to 757db1f Compare September 27, 2023 16:30
@cheina97 cheina97 changed the title CRD Replicator unit test fix Unit tests: envtest server new crds path Sep 27, 2023
@cheina97 cheina97 force-pushed the frc/CrdReplicatorTestFix branch from 757db1f to 5eb26fb Compare September 27, 2023 16:32
@cheina97 cheina97 marked this pull request as draft September 27, 2023 16:32
@cheina97 cheina97 force-pushed the frc/CrdReplicatorTestFix branch 3 times, most recently from 47ff4c7 to b0c968e Compare September 27, 2023 17:19
@cheina97 cheina97 force-pushed the frc/CrdReplicatorTestFix branch from b0c968e to 640e98a Compare September 27, 2023 17:21
@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 marked this pull request as ready for review September 27, 2023 17:48
@aleoli
Copy link
Member

aleoli commented Sep 28, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 28, 2023
@adamjensenbot adamjensenbot merged commit 320f059 into liqotech:network-external Sep 28, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 28, 2023
@cheina97 cheina97 deleted the frc/CrdReplicatorTestFix branch September 29, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants