Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Network: liqoctl network fixes #2110

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Oct 24, 2023

Description

This PR fixes some bugs and adds features for the liqoctl network command.

  • option to wait for the Connections to be Established when issuing the network connect command
  • install external network resources on liqo-tenants namespaces, unless the user explicitly sets the namespaces
  • set ownerRef to Gateway on PublicKeys
  • same MTU between Client and Server
  • refactor clusterID to remoteClusterID when necessary

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 changed the title External Network: liqoctl wait on connections + fixes External Network: liqoctl network connect fixes Oct 24, 2023
@fra98 fra98 changed the title External Network: liqoctl network connect fixes External Network: liqoctl network fixes Oct 24, 2023
@fra98 fra98 force-pushed the frt/liqoctl-wait-conn branch from e234df9 to 6406140 Compare October 25, 2023 09:12
@fra98 fra98 force-pushed the frt/liqoctl-wait-conn branch 2 times, most recently from 7e8131c to 074e9bf Compare October 26, 2023 15:38
@fra98 fra98 marked this pull request as ready for review October 26, 2023 15:39
pkg/liqoctl/wait/wait.go Outdated Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/liqoctl-wait-conn branch 2 times, most recently from d46a282 to af25af0 Compare October 27, 2023 10:38
Copy link
Member

@cheina97 cheina97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fra98 fra98 force-pushed the frt/liqoctl-wait-conn branch from af25af0 to 06d695e Compare October 27, 2023 12:40
@fra98
Copy link
Member Author

fra98 commented Oct 27, 2023

/test

@fra98 fra98 merged commit 920a5cc into liqotech:network-external Oct 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants