-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Network: liqoctl network fixes #2110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
fra98
changed the title
External Network: liqoctl wait on connections + fixes
External Network: liqoctl network connect fixes
Oct 24, 2023
fra98
changed the title
External Network: liqoctl network connect fixes
External Network: liqoctl network fixes
Oct 24, 2023
fra98
force-pushed
the
frt/liqoctl-wait-conn
branch
from
October 25, 2023 09:12
e234df9
to
6406140
Compare
fra98
force-pushed
the
frt/liqoctl-wait-conn
branch
2 times, most recently
from
October 26, 2023 15:38
7e8131c
to
074e9bf
Compare
cheina97
reviewed
Oct 27, 2023
cheina97
reviewed
Oct 27, 2023
cheina97
reviewed
Oct 27, 2023
cheina97
approved these changes
Oct 27, 2023
fra98
force-pushed
the
frt/liqoctl-wait-conn
branch
2 times, most recently
from
October 27, 2023 10:38
d46a282
to
af25af0
Compare
cheina97
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fra98
force-pushed
the
frt/liqoctl-wait-conn
branch
from
October 27, 2023 12:40
af25af0
to
06d695e
Compare
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some bugs and adds features for the
liqoctl network
command.Established
when issuing thenetwork connect
commandclusterID
toremoteClusterID
when necessary