External Network: ping disable #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
frc/pingdisable
branch
2 times, most recently
from
7c3388c to
c01369b
Compare
|
/rebase test=true |
cheina97
force-pushed
the
frc/pingdisable
branch
6 times, most recently
from
b5e945d to
7cafb5b
Compare
aleoli
force-pushed
the
network-external
branch
from
920a5cc to
46948de
Compare
cheina97
force-pushed
the
frc/pingdisable
branch
4 times, most recently
from
58df296 to
b7d26d2
Compare
fra98
approved these changes
Nov 13, 2023
cheina97
force-pushed
the
frc/pingdisable
branch
from
573e3ae to
4d302f5
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
frc/pingdisable
branch
from
4d302f5 to
264c627
Compare
cheina97
force-pushed
the
frc/pingdisable
branch
from
264c627 to
3c47fed
Compare
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gives the possibility to disable the ping from the gateway container's flags.
In case the ping is disabled the connection will be always true.
A flag to disable the connection controller is added. This should be useful in case the check of the connection is performed by the tunnel technology, instead of the connection controller.