DAT-18667: Updated snapshot test suite test files.

.github/workflows/lth.yml

@@ -28,7 +28,7 @@ jobs:
     strategy:
       max-parallel: 1
       matrix:
-        liquibase-support-level: [Foundational, Contributed] # Define the different test levels to run
+        liquibase-support-level: [Foundational, Contributed, Advanced] # Define the different test levels to run
       fail-fast: false # Set fail-fast to false to run all test levels even if some of them fail
 
     steps:

src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java

@@ -1,6 +1,9 @@
 package liquibase.ext.databricks;
 
 import liquibase.harness.AdvancedHarnessSuite;
+import liquibase.harness.snapshot.SnapshotObjectTests;
+import org.junit.platform.suite.api.SelectClasses;
 
+@SelectClasses({SnapshotObjectTests.class})
 public class AdvancedExtensionHarnessTestSuite extends AdvancedHarnessSuite {
 }

src/test/resources/liquibase/harness/snapshot/changelogs/databricks/addColumn.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<databaseChangeLog
+        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+         http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+    <changeSet id="1" author="as">
+        <createTable tableName="test_table">
+            <column name="test_column" type="INT"/>
+        </createTable>
+        <rollback/>
+    </changeSet>
+    <changeSet id="2" author="as">
+        <addColumn tableName="test_table">
+            <column name="stringColumn" type="STRING" value="INITIAL_VALUE"/>
+            <column name="varcharColumn" type="varchar(25)" value="INITIAL_VALUE"/>
+            <column name="intColumn" type="int" valueNumeric="5"/>
+            <column name="dateColumn" type="date" valueDate="2020-09-21"/>
+        </addColumn>
+        <rollback>
+            <dropTable tableName="test_table"/>
+        </rollback>
+    </changeSet>
+</databaseChangeLog>

src/test/resources/liquibase/harness/snapshot/changelogs/databricks/addPrimaryKey.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<databaseChangeLog
+        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+         http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+    <changeSet id="1" author="as">
+        <createTable tableName="test_table">
+            <column name="id" type="INT">
+              <constraints nullable="false"/>
+            </column>
+        </createTable>
+        <rollback>
+            <dropTable tableName="test_table"/>
+        </rollback>
+    </changeSet>
+    <changeSet id="2" author="as">
+        <addPrimaryKey
+                columnNames="id"
+                constraintName="test_pk"
+                tableName="test_table"
+                validate="true"/>
+        <rollback>
+            <dropPrimaryKey tableName="test_table"
+                            constraintName="test_pk"/>
+        </rollback>
+    </changeSet>
+</databaseChangeLog>

src/test/resources/liquibase/harness/snapshot/changelogs/databricks/addUniqueConstraint.xml

@@ -4,13 +4,13 @@
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
          http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
-    <!--    Unique constraints are not supported for Databrick. Remove test data for this changetype after refactoring of snapshot test-->
-    <changeSet id="1" author="cody">
-        <createTable tableName="test_table">
+    <!--Changetype not supported. We need to override test-harness existing changelog in order to work for this suite-->
+    <changeSet id="1" author="as">
+        <createTable tableName="test_table_unique">
             <column name="id" type="INT"/>
         </createTable>
         <rollback>
-            <dropTable tableName="test_table"/>
+            <dropTable tableName="test_table_unique"/>
         </rollback>
     </changeSet>
 </databaseChangeLog>

src/test/resources/liquibase/harness/snapshot/changelogs/databricks/createIndex.xml

@@ -4,6 +4,7 @@
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
          http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+    <!--Changetype not supported. We need to override test-harness existing changelog in order to work for this suite-->
     <changeSet id="1" author="codydavis">
         <createTable tableName="test_table_index">
             <column name="id" type="INT"/>

src/test/resources/liquibase/harness/snapshot/changelogs/databricks/createTable.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<databaseChangeLog
+        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+         http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+    <changeSet id="1" author="as">
+        <createTable tableName="snapshot_test_table">
+            <column name="snapshot_test_column" type="INT"/>
+        </createTable>
+        <rollback>
+            <dropTable tableName="snapshot_test_table"/>
+        </rollback>
+    </changeSet>
+</databaseChangeLog>

src/test/resources/liquibase/harness/snapshot/changelogs/databricks/createView.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<databaseChangeLog
+        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+         http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+    <changeSet id="1" author="mykhailo">
+        <createTable tableName="view_table">
+            <column name="test_column" type="INT"/>
+        </createTable>
+        <rollback>
+            <dropTable tableName="view_table"/>
+        </rollback>
+    </changeSet>
+    <changeSet id="2" author="mykhailo">
+        <createView viewName="test_view">
+            select test_column from main.liquibase_harness_test_ds.view_table
+        </createView>
+        <rollback>
+            <dropView viewName="test_view"/>
+        </rollback>
+    </changeSet>
+</databaseChangeLog>

src/test/resources/liquibase/harness/snapshot/changelogs/databricks/snapshotCatalogAndSchema.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<databaseChangeLog
+        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
+         http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+    <changeSet id="1" author="mykhailo">
+        <createTable tableName="snapshot_test_table">
+            <column name="snapshot_test_column" type="INT"/>
+        </createTable>
+        <rollback>
+            <dropTable tableName="snapshot_test_table"/>
+        </rollback>
+    </changeSet>
+</databaseChangeLog>

src/test/resources/liquibase/harness/snapshot/expectedSnapshot/databricks/addColumn.json

@@ -18,6 +18,15 @@
             }
           }
         },
+        {
+           "column": {
+            "name": "stringColumn",
+             "nullable": true,
+            "type": {
+              "typeName": "STRING"
+            }
+          }
+        },
         {
           "column": {
             "name": "varcharColumn",

src/test/resources/liquibase/harness/snapshot/expectedSnapshot/databricks/addUniqueConstraint.json

@@ -4,7 +4,7 @@
       "liquibase.structure.core.Table": [
         {
           "table": {
-            "name": "test_table"
+            "name": "test_table_unique"
           }
         }
       ]

src/test/resources/liquibase/harness/snapshot/expectedSnapshot/databricks/createTable.json

@@ -0,0 +1,23 @@
+{
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Table": [
+        {
+          "table": {
+            "name": "snapshot_test_table"
+          }
+        }
+      ],
+      "liquibase.structure.core.Column": [
+        {
+          "column": {
+            "name": "snapshot_test_column",
+            "type": {
+              "typeName": "INT"
+            }
+          }
+        }
+      ]
+    }
+  }
+}

src/test/resources/liquibase/harness/snapshot/expectedSnapshot/databricks/createView.json

@@ -0,0 +1,21 @@
+{
+  "snapshot": {
+    "objects": {
+      "liquibase.structure.core.Table": [
+        {
+          "table": {
+            "name": "view_table"
+          }
+        }
+      ],
+      "liquibase.structure.core.View": [
+        {
+          "view": {
+            "definition": "select test_column from main.liquibase_harness_test_ds.view_table",
+            "name": "test_view"
+          }
+        }
+      ]
+    }
+  }
+}