-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions are not upgraded #192
Comments
@kimmoahola Thanks for your reporting! I didn't have a good library to rewrite yaml, so I made a simple one. To fix this problem, we need to find or create a library that correctly parses and rewrites yaml. FYI, If antlr had a yaml grammer, I would have wanted to use it. |
Just coming here to report something very similar -- I have: - name: Clojure CLI
uses: DeLaGuardo/setup-clojure@master
with:
tools-deps: '1.11.1.1208'
|
@seancorfield Oh, I could reproduce the problem. Thanks! |
It is a bug in liquidz/rewrite-indented. |
@seancorfield I've fixed the problem in v2.5.1095. Please use |
Good to know -- thanks! |
Works beautifully, now I've switched to |
I still encounter the original issue author's problem: When a workflow contains multiple references to |
@devurandom Could you show me your YAML file? |
I am able to reproduce it with this file: jobs:
example:
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
with:
repository: antq/example
antq says "upgraded", but the content of the file stays exactly the same. |
@devurandom Thanks! I could reproduce the problem. |
@devurandom Sorry for late work. |
@devurandom Thanks for your confirmation! |
I have the following GHA yml file:
My deps.edn looks like this:
When I run antq it will output:
But it will not update those two checkout steps.
And another issue is that the
test.yml
will get bogus content. The lint2 job get duplicated:The original test.yml has two empty lines before
lint2:
. If I remove the other empty line then the content is not duplicated (but steps are still not upgraded).If I add two spaces to the beginning of the lines
- uses:
then antq will upgrade those steps. The original test.yml file is valid yaml (maybe not properly formated, but still valid).The text was updated successfully, but these errors were encountered: