Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't evaluate forms when they are folded #295

Open
kkharji opened this issue Nov 30, 2020 · 11 comments
Open

Can't evaluate forms when they are folded #295

kkharji opened this issue Nov 30, 2020 · 11 comments
Labels
bug Something isn't working

Comments

@kkharji
Copy link
Contributor

kkharji commented Nov 30, 2020

Hey @liquidz, is it possible to fix this.
iced-vim-issue

Thanks

@liquidz
Copy link
Owner

liquidz commented Nov 30, 2020

@tami5 Oh, nice catch!
I'll have a look, but it may not be easy I think

@liquidz liquidz added the bug Something isn't working label Dec 1, 2020
@liquidz
Copy link
Owner

liquidz commented Dec 2, 2020

It may be fixed by using getline instead of visual mode.

@liquidz
Copy link
Owner

liquidz commented Dec 2, 2020

@tami5 Could you try dev branch?
It may be fixed (WIP)

@liquidz
Copy link
Owner

liquidz commented Dec 3, 2020

Oh, had broken. sorry
I fixed but it may be buggy yet.

@liquidz
Copy link
Owner

liquidz commented Dec 3, 2020

a45e9f1 is breaking IcedFormat command...

@kkharji
Copy link
Contributor Author

kkharji commented Dec 3, 2020

Works well for me. I think that fixes this issue. Thanks so much @liquidz

@kkharji kkharji closed this as completed Dec 3, 2020
@liquidz
Copy link
Owner

liquidz commented Dec 3, 2020

@tami5 Sorry a45e9f1 moves to bugfix/eval-folded-code branch once, and I reverted dev branch.

a45e9f1 breaks processes which depends on gv,
so I'll look for another solution...

@liquidz liquidz reopened this Dec 3, 2020
@liquidz
Copy link
Owner

liquidz commented Dec 11, 2020

I'll try to use vim-sexp's af text object
https://github.com/guns/vim-sexp/blob/master/doc/vim-sexp.txt#L72

@kkharji
Copy link
Contributor Author

kkharji commented Dec 11, 2020

Thats nice. Thanks @liquidz

@liquidz
Copy link
Owner

liquidz commented Dec 12, 2020

@tami5 I force updated bugfix/eval-folded-code branch.

It seems work well for now, but I'll continue to test more.

@liquidz
Copy link
Owner

liquidz commented Dec 15, 2020

Hmm.. af text object is 4x slower than current process on large code base 😢
I cannot merge to master / dev with this performance.

Current workaround is to overwrite <Leader>et mapping as follows.

nmap <Leader>et <Plug>(iced_eval)<Plug>(sexp_outer_top_list)``

This mapping is using a feature as same as af text object, so as I said, it canbe slow on large code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants