Skip to content
This repository has been archived by the owner on Feb 23, 2025. It is now read-only.

:IcedCleanNs removes :clj-kondo/ignore reader comments #465

Open
noahmoss opened this issue Sep 19, 2023 · 2 comments
Open

:IcedCleanNs removes :clj-kondo/ignore reader comments #465

noahmoss opened this issue Sep 19, 2023 · 2 comments
Assignees

Comments

@noahmoss
Copy link

Hey @liquidz!

If a namespace has #_{:clj-kondo/ignore [:deprecated-namespace]} above a required namespace, it is removed after running :IcedCleanNs. Would it be possible for the command to retain these comments?

@liquidz
Copy link
Owner

liquidz commented Sep 19, 2023

@noahmoss Thanks for your report!

:IcedCleanNs uses the refactor-nrepl's feature, so I'll have a look at the process in refactor-nrepl :)

@liquidz liquidz self-assigned this Sep 19, 2023
@liquidz
Copy link
Owner

liquidz commented Sep 30, 2023

@noahmoss Sorry for late reply 🙇
Hmm, currently there is no way to retain those comments in refactor-nrepl.

And also tool-specific rules like #_:clj-kondo/ignore seems not to be welcomed.
clojure-emacs/refactor-nrepl#359 (comment)

I have no plan to implement own implementation of retaining those comments, since it can also be excluded in .clj-kondo/config.edn.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants