String "Lita" is hardcoded into messages

[rjhornsby]

In lita-default-handlers/locales/en.yml, the string Lita is hardcoded into several messages, rather than using the bot's identity. This can cause confusion if the bot is named something else because you get an interaction like this:

joeuser: hal9000 help
hal9000: info - Replies with the current version of Lita.
hal9000: find SEARCH_TERM - Find a Lita user by ID, name, or mention name.

Using the name "Lita" creates a bit of an identity crisis for the bot, and doesn't make sense to the users.

To be clear, I'm not referring to module or variable names used in the code, but rather Lita as a string literal used in output.

[jimmycuadra]

Hmm... I can see it as a bit of a usability issue, although the particular examples you listed are correct in using "Lita" since it's referring to the Lita program itself. I'm not sure of a better way to phrase it.

[rjhornsby]

In my head, I was pondering a way to stick a %{bot.name} type template parameter into the yaml. If for the examples above we don't want to do that here's a couple of ideas -

hal9000: info - Replies with the current version of the Lita engine.

The second example

hal9000: find SEARCH_TERM - Find a Lita user by ID, name, or mention name.

is a little more challenging because you can't simply drop Lita as a modifier of user because of the ambiguity that creates. Maybe Find a chat user...?