Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 & Joomla 4.2.2 issue #54

Open
attis119 opened this issue Sep 5, 2022 · 2 comments
Open

PHP 8 & Joomla 4.2.2 issue #54

attis119 opened this issue Sep 5, 2022 · 2 comments

Comments

@attis119
Copy link

attis119 commented Sep 5, 2022

Hi,
As PHP 7.4 is getting to its EOL, on a sandbox site I tried to change to PHP 8. After that warnings started to show up:

Warning: Undefined array key "view" in /home/......../lscache/components/com_sppagebuilder.php on line 17
Warning: Cannot modify header information - headers already sent by (output started at /home/......../lscache/components/com_sppagebuilder.php:17) in /home/........lscache/lscachebase.php on line 211

SP Pagebuilder is Pro 4.0.3
After falling back to PHP 7.4 warnings vanished.
Could you please have a look?

@attis119
Copy link
Author

attis119 commented Sep 6, 2022

Hi
Meanwhile I added isset function to line 17 in com_sppagebuilder.php

17	if ( isset ($this->plugin->pageElements['view'] ))
18	{
19	      if($this->plugin->pageElements['view']!='page'){
20                $this->plugin->pageCachable = false;
21            }
22           else{
23               $link = JUri::getInstance()->getQuery();
24               if(!empty($link)){
25               }
26           }
27        }

Warnings disapperad, tested with SPPB Free 3.8.8 and Pro 4.0.3.
J4 LScache plugin seems to be working on PHP 8 with SPPB this way, but please check if this is a final solution.

@uglyeoin
Copy link

uglyeoin commented Jun 1, 2023

I love that you actually posted the solution. It's such a shame that this was months ago and the issue is still left open with no reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants