Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Prettier config #592

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Revise Prettier config #592

merged 2 commits into from
Nov 13, 2023

Conversation

tynanbe
Copy link
Contributor

@tynanbe tynanbe commented Nov 11, 2023

A followup to #591 that fixes some unexpected issues and improves the formatter config.

Per the Prettier PHP plugin readme, the formatter shouldn't yet be used on mixed PHP/HTML content in production; and indeed, I encountered some issues before I saw that (see https://github.com/prettier/plugin-php/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Ainline).

@hi-hai hi-hai merged commit 0df99da into litespeedtech:dev Nov 13, 2023
1 check passed
@tynanbe tynanbe deleted the prettier_format branch November 13, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants