From 6566b53c71df3426ae80b6f1870a1d0eb21715ae Mon Sep 17 00:00:00 2001
From: tynanbe <contact@tynan.be>
Date: Fri, 1 Dec 2023 04:28:51 -0600
Subject: [PATCH] Fix an issue where cleaning post revisions would fail when
 cleaning postmeta

---
 src/db-optm.cls.php | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/src/db-optm.cls.php b/src/db-optm.cls.php
index 87dd1eceb..806963ae7 100644
--- a/src/db-optm.cls.php
+++ b/src/db-optm.cls.php
@@ -150,11 +150,13 @@ private function _db_clean($type)
 				$postmeta = "`$wpdb->postmeta`";
 				$posts = "`$wpdb->posts`";
 
-				$sql_postmeta = "
-					$postmeta
-					LEFT JOIN $posts
-					ON $posts.ID = $postmeta.post_id
-				";
+				$sql_postmeta_join = function ($table) use ($postmeta, $posts) {
+					return "
+						$postmeta
+						CROSS JOIN $table
+						ON $posts.ID = $postmeta.post_id
+					";
+				};
 
 				$sql_where = "WHERE $posts.post_type = 'revision'";
 
@@ -162,6 +164,7 @@ private function _db_clean($type)
 
 				if (!$rev_max) {
 					$sql_where = "$sql_where $sql_add";
+					$sql_postmeta = $sql_postmeta_join($posts);
 					$wpdb->query("DELETE $postmeta FROM $sql_postmeta $sql_where");
 					$wpdb->query("DELETE FROM $posts $sql_where");
 				} else {
@@ -178,13 +181,14 @@ private function _db_clean($type)
 					$res = $wpdb->get_results($sql);
 					$sql_where = "
 						$sql_where
-						AND $posts.post_parent = %d
-						ORDER BY $posts.ID
+						AND post_parent = %d
+						ORDER BY ID
 						LIMIT %d
 					";
+					$sql_postmeta = $sql_postmeta_join("(SELECT ID FROM $posts $sql_where) AS $posts");
 					foreach ($res as $v) {
 						$args = array($v->post_parent, $v->del_max);
-						$sql = $wpdb->prepare("DELETE $postmeta FROM $sql_postmeta $sql_where", $args);
+						$sql = $wpdb->prepare("DELETE $postmeta FROM $sql_postmeta", $args);
 						$wpdb->query($sql);
 						$sql = $wpdb->prepare("DELETE FROM $posts $sql_where", $args);
 						$wpdb->query($sql);