Fix an issue where images won't be pulled with older versions of WordPress #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-hai
reviewed
Jan 2, 2024
src/img-optm.cls.php
Outdated
| @@ -1124,7 +1134,7 @@ public function pull($manual = false) | |||
| $total_pulled_ori++; | |||
| }; | |||
|
|
|||
| if (class_exists('Requests')) { | |||
| if (class_exists('\WpOrg\Requests\Requests') && class_exists('\WpOrg\Requests\Autoload') && !version_compare(PHP_VERSION, '5.6.0', '<')) { | |||
There was a problem hiding this comment.
For !version_compare(PHP_VERSION, '5.6.0', '<'), why not use version_compare(PHP_VERSION, '5.6.0', '>=')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requestsclass didn't always exist at the current namespace.Autoloadclass is a fairly recent addition.Additionally, the
Requestsclass doesn't support all the oldest PHP versions that LSCWP does.This PR should limit parallel pull to only the most recent versions of WordPress.
Additionally, parallel pull won't be used for PHP < v5.6, as per the Requests changelog