Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug(docs): Documentation changes cause Litestar docs to encounter buildtime errors #142

Closed
JacobCoffee opened this issue Mar 16, 2024 · 1 comment
Closed

Bug(docs): Documentation changes cause Litestar docs to encounter buildtime errors #142

JacobCoffee opened this issue Mar 16, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@JacobCoffee
Copy link
Member

JacobCoffee commented Mar 16, 2024 •
edited
Loading

Description

When building docs, changes in AA are sometimes causing Litestar build steps to warn/fail.

Solution would be to set up a CI workflow to check out the develop branch of Litestar and build the docs against the latest AA codebase, and fail if any build errors are encountered.

This way we can ensure (up?) downstream build success.

URL to code causing the issue

https://github.com/litestar-org/litestar/actions/runs/8206934469/job/22447123447?pr=3169
@JacobCoffee JacobCoffee added bug Something isn't working documentation Improvements or additions to documentation labels Mar 16, 2024
@JacobCoffee JacobCoffee mentioned this issue Mar 16, 2024
Merged
@cofin
Copy link
Member

cofin commented Oct 22, 2024

Closed by litestar-org/litestar#3169

@cofin cofin closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cofin @JacobCoffee