From bc6d5022f83c50bd28122edde0fba1fcbec17b8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janek=20Nouvertn=C3=A9?= Date: Thu, 18 Jan 2024 21:42:18 +0100 Subject: [PATCH] ci: Fix release link in released fix notifier (#2997) * Fix issue link * Depend on release --- .github/workflows/notify_released_issues/notify.js | 2 +- .github/workflows/publish.yml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/notify_released_issues/notify.js b/.github/workflows/notify_released_issues/notify.js index 4e2598f750..317e22c2d8 100644 --- a/.github/workflows/notify_released_issues/notify.js +++ b/.github/workflows/notify_released_issues/notify.js @@ -1,7 +1,7 @@ module.exports = async ({github, context, core}) => { const issues = JSON.parse(process.env.CLOSED_ISSUES) - const releaseURL = context.payload.release.url + const releaseURL = context.payload.release.html_url const releaseName = context.payload.release.name const baseBody = "A fix for this issue has been released in" const body = baseBody + ` [${releaseName}](${releaseURL})` diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index ebb4966dd3..13cc072191 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -99,6 +99,7 @@ jobs: uses: pypa/gh-action-pypi-publish@release/v1 notify-issues: + needs: publish-release name: Notify issues uses: ./.github/workflows/notify-released-issues.yml with: