Oye sms preferences sync #660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
========================================
Coverage 98.75% 98.75%
========================================
Files 468 471 +3
Lines 21523 21632 +109
========================================
+ Hits 21254 21363 +109
Misses 269 269 ☔ View full report in Codecov by Sentry. |
rgalanakis
force-pushed
the
oye-sms-preferences-sync
branch
from
54c95ca to
7fdb893
Compare
DeeTheDev
force-pushed
the
oye-sms-preferences-sync
branch
2 times, most recently
from
7fdb893 to
0aa5a00
Compare
Setup HTTP requests for oye app API to sync sms preferences. Upsert contact sms preferences when changing preferences. Test
Fix migration file numbers naming. Add search cabaility to oye contacts GET http call. Use it to search for members by phone number. Update method namings and descriptions
rgalanakis
force-pushed
the
oye-sms-preferences-sync
branch
from
23ab676 to
3977a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #647
Sync oye contact sms preferences for members async/periodically (every 24th hour?).
When member updates their marketing preferences through API, also update the Oye contact preference to stay in sync.