litmus-agent helm rendering fails with duplicate labels for sub helm chart

[ayanevbg]

When I try to install litmus-agent helm chart for versions >=0.2.0 it fails with the following error:

Sub charts - https://github.com/litmuschaos/litmus-helm/tree/master/charts/litmus-agent/charts have duplicate labels for

litmuschaos.io/app:
app.kubernetes.io/name:
app.kubernetes.io/instance:

This is caused because the deployments have both .selectorLabels and .labels added to the manifest.

Example:

litmus-helm/charts/litmus-agent/charts/chaos-exporter/templates/deployment.yaml

Lines 21 to 22 in 31a0a30

	{{- include "chaos-exporter.selectorLabels" . | nindent 8 }}
	{{- include "chaos-exporter.labels" . | nindent 8 }}

In the helpers the selectorLabels are included in labels :

litmus-helm/charts/litmus-agent/charts/chaos-exporter/templates/_helpers.tpl

Line 38 in 31a0a30

{{ include "chaos-exporter.selectorLabels" . }}

[Calvinaud]

Hello,

The issue was introduced in my PR : #327.
I create a new PR to fix it.
I don't know why but I had no issue when deploying the chart.

[uditgaurav]

Thanks @Calvinaud for the PR. Please feel free to update the PR with master.