Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link styling enforcement #1187

Open
bryson-g opened this issue Dec 10, 2024 · 0 comments
Open

Link styling enforcement #1187

bryson-g opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
dashboard LittleHorse administrative dashboard. refactor Technical debt, refactors, and missing tests. Use `bug` if it affects users directly.

Comments

@bryson-g
Copy link
Contributor

bryson-g commented Dec 10, 2024

LinkWithTenant.tsx is often implemented with hyperlink styling from each reference, which it should instead provide a prop to allow hyperlink styling by implementing shadcn's Button link variant.

This is a problem because this creates potential discrepancies of design for the same exact functionality across the app. Fixing this would also make developing and using the LinkWithTenant since you could easily use the desired hyperlink style without making it again and again.

@bryson-g bryson-g added dashboard LittleHorse administrative dashboard. refactor Technical debt, refactors, and missing tests. Use `bug` if it affects users directly. labels Dec 10, 2024
@bryson-g bryson-g self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard LittleHorse administrative dashboard. refactor Technical debt, refactors, and missing tests. Use `bug` if it affects users directly.
Projects
Status: No status
Development

No branches or pull requests

1 participant