Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: ReportTaskRun serialization failure perceived as TaskTimeout #1279

Open
Snarr opened this issue Feb 9, 2025 · 0 comments
Open

server: ReportTaskRun serialization failure perceived as TaskTimeout #1279

Snarr opened this issue Feb 9, 2025 · 0 comments
Assignees
Labels
bug An issue with correctness, stability, performance, or API conformance. server Affects the core LH Server code.

Comments

@Snarr
Copy link
Member

Snarr commented Feb 9, 2025

Bug

When the LittleHorse Server fails to serialize a ReportTaskRun request, it returns an LHApiException early, which means we don't forward a record through our Kafka Streams Topology reporting the state of the TaskRun. This means that the TaskRun state is usually perceived as a Timeout by the server, since no state is reported. We should forward a ReportTaskRun Deserialization Error or something equivalent as the state of the TaskRun to our topology.

Steps to reproduce

  1. Register any TaskDef with the LittleHorse Server
  2. Register any WfSpec that uses that TaskDef with the LittleHorse Server
  3. Run a Task Worker for your TaskDef
  4. Run the workflow and execute that Task
  5. Your Task Worker should pick up the TaskRun via a PollTask request
  6. Intercept the ReportTask RPC call before it is sent to the server by your Task Worker
  7. Use an invalid json_obj value for the ReportTask.Output, such as a non-JSON formatted string "test"
  8. The server will fail to serialize the ReportTask request and interpret the Task as timed out after the timeout period expires
@Snarr Snarr added bug An issue with correctness, stability, performance, or API conformance. server Affects the core LH Server code. labels Feb 9, 2025
@Snarr Snarr changed the title Server ReportTaskRun serialization failure perceived as TaskTimeout server: ReportTaskRun serialization failure perceived as TaskTimeout Feb 9, 2025
@coltmcnealy-lh coltmcnealy-lh added this to the LittleHorse 1.0 milestone Feb 13, 2025
@Snarr Snarr self-assigned this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with correctness, stability, performance, or API conformance. server Affects the core LH Server code.
Projects
None yet
Development

No branches or pull requests

2 participants