Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal flicker #2799

Open
psugihara opened this issue Sep 24, 2024 · 1 comment
Open

Modal flicker #2799

psugihara opened this issue Sep 24, 2024 · 1 comment
Labels
area:frontend Related to UI/UX

Comments

@psugihara
Copy link

Environment

  • Elixir & Erlang/OTP versions (elixir --version): Erlang/OTP 27 [erts-15.0] [source] [64-bit] [smp:16:2] [ds:16:2:10] [async-threads:1] [jit:ns] [x86_64-pc-linux-gnu], Elixir 1.17.2, Phoenix 1.7.14
  • Operating system:
  • How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): Docker on hugging face
  • Livebook version (use git rev-parse HEAD if running with mix): 0.14.2
  • Browsers that reproduce this bug (the more the merrier): mac safari desktop

Current behavior

I see this flicker on almost every modal: Add secret, Add file storage, Add environment variable, but not on the "?" user profile edit button.

Screen.Recording.2024-09-24.at.7.11.41.AM.mov

Also here's a weird flash of unstyled content that consistently happened on every single load. Guessing this is from using font-display: swap
https://github.com/user-attachments/assets/7d585c74-19aa-4067-b1cc-0c3940c58409

Expected behavior

No jank, no wiggle!

@josevalim
Copy link
Contributor

Beautiful, thank you! They seem to be JS/CSS issues, we will dig deeper.

@josevalim josevalim added the area:frontend Related to UI/UX label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Related to UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants