Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer maintained? Happy to jump in 👋 #118

Open
jamilabreu opened this issue Feb 8, 2021 · 17 comments
Open

No longer maintained? Happy to jump in 👋 #118

jamilabreu opened this issue Feb 8, 2021 · 17 comments

Comments

@jamilabreu
Copy link

Hi @liveforeverx! I've been jumping in with Dlex, and noticed you're not as active anymore.

If you could give me a quick overview of how everything works (Confused about Adapters, Protocols, etc), I'm happy to take over. Lmk 😃

@liveforeverx
Copy link
Owner

liveforeverx commented Feb 15, 2021

Hi, @jamilabreu !

Sorry for late answer.

I'm kind of waiting, what the new direction with GraphQL it will take, so I'm not sure where DGraph goes and where should a driver go at the moment.

But I'm happy to have new maintainers.

You can mail me and we can have hangouts, telegram, skype or any other possibility to discuss everything in person, dive in a code and discuss further changes. What do you think?

@martinthenth
Copy link
Contributor

martinthenth commented Feb 26, 2021

Hi @liveforeverx and @jamilabreu,

We could open an RFC issue, to gather changes to be made for a version 1 release. Dlex does a lot of things right, is up to date on the current version of Dgraph (to my knowledge), and can be used in production (I have).

For example:

  1. I believe much of the internal API can be simplified to just mutate() and all() / query(), because set() and mutate() do a lot of the same things.
  2. set and delete should be possible in a single query as per Dgraph docs (which we can do with pattern matches).
  3. The typespecs have to be updated.
  4. And I believe Ecto and Dlex can be separated, because Ecto can do the heavy lifting of changesets, and Dlex only needs to do Dlex.set(map) where map is a result of the Ecto.Changeset changes field.

@jamilabreu
Copy link
Author

jamilabreu commented Feb 26, 2021

@liveforeverx I'd love a quick tour over zoom or hangouts. I'm free next week starting on Tuesday, any day after 5pm EST. Let me know what works for you!

@martinthenth - you're welcome to join too if you'd like! Happy to see there's interest in keeping Dlex up-to-date 😃 An RFC issue sounds like a good start - want to work on it together?

@liveforeverx
Copy link
Owner

@martinthenth Yes, it is up to date, usually I test against every new version.

  1. The set API should be deprecated. I agree, this was still there on backwards-compatibility reason.
  2. It is already possible (I try to cover all functionality, except for GraphQL atm): https://github.com/liveforeverx/dlex/blob/master/test/dlex_test.exs#L285-L288
  3. Yes, that's true
  4. Completely agree, for version 1.0 - it should. For future developing, I think, it is better to have one place at the moment. For library users of dlex it shouldn't be a problem, as it optionally depends on ecto.

@martinthenth
Copy link
Contributor

@jamilabreu Yes, I can help. :)

@liveforeverx Great! I'm glad the base-API of Dgraph is stable through the different versions. 2: I hadn't seen that, my bad.

@jamilabreu
Copy link
Author

@liveforeverx are you free to chat this week? Here's a calendly link with my available times, looking forward to it!

https://calendly.com/abreu-jamil/30

Github would be better with private messages :)

@benwoodward
Copy link

Can someone explain the difference between this repo and the one here—https://github.com/pixelmonster-ou/dlex?

@jamilabreu
Copy link
Author

@benwoodward Hi - I'm not sure they're related, looks like a fork?

@benwoodward
Copy link

I should have updated here, the author replied with this:

Hi @benwoodward,

The one you linked is the real one. This one just has custom changes I did for https://github.com/pixelmonster-ou/metagraph such as reverse relations, translations etc.

I would suggest you go with @liveforeverx's repo as it's more clean and more up2date.

@jnylen
Copy link

jnylen commented May 25, 2021

I'm fine merging my fork into this one if @liveforeverx wants to.

Basically the fork was made so I could add quite custom stuff to model databases such as reverse relationships and mainly translations as this couldn't be handled in a good way that I expected.

@liveforeverx if you are fine with merging it, do you want me to start splitting up the changes into multiple PRs?

@geoyws
Copy link

geoyws commented Oct 26, 2021

Really hoping this project will pick up again!
I'm learning Elixir and want to use it with Dgraph for a small project 😄

@m0dnar
Copy link

m0dnar commented Oct 29, 2021

👋🏼 I've just pushed an updated fork of Dlex with:

  • Updated dependencies
  • Updated api.ex and api.proto
  • Updated fields
  • Deprecated set in favor of mutate
  • Support for redacted fields
  • Updated README with Phoenix instructions

@martinthenth would love some help separating Ecto from Dlex 💯

@jnylen happy to accept your work on translations / reverse relationships

https://github.com/m0dnar/dlex

Excited to get this project going again!

cc: @geoyws @benwoodward @liveforeverx

@benwoodward
Copy link

👋🏼 I've just pushed an updated fork of Dlex with:

Fantastic! Are you gonna create a PR or maintain a separate fork?

@m0dnar
Copy link

m0dnar commented Oct 30, 2021

Fantastic! Are you gonna create a PR or maintain a separate fork?

Separate for now, but I'm not against merging down the road!

@goravbhootra
Copy link

I had raised two PRs which are still not merged. In case they are useful, I will be happy to rebase and update, as needed. Keen on contributing going forward as well.

Cheers!

@m0dnar
Copy link

m0dnar commented Nov 12, 2021

@goravbhootra I actually added the changes you suggested in both of your PRs in my fork -- very helpful and appreciated :D Send any others over!

@tjtrabue
Copy link

Is this project still maintained? It's still by far the best dgraph client for Elixir, and it'd be a shame for it to fall away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants