Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCAudioDevice "initialize(with delegate:" method is not called #1

Open
ronnyf opened this issue Nov 8, 2023 · 1 comment
Open

Comments

@ronnyf
Copy link

ronnyf commented Nov 8, 2023

When creating an RTCPeerConnection with RTCAudioDevice parameter:

RTCPeerConnectionFactory(encoderFactory: encoderFactory, decoderFactory: decoderFactory, audioDevice: audioDevice)

The audio device class gets instantiated correctly, but the method initialize(with delegate: RTCAudioDeviceDelegate) -> Bool is never called. Might this have something to do with your custom RTCDefaultAudioProcessingModule ?

Could you please put some higher priority on fixing this? 🙏

@hiroshihorie
Copy link
Member

hiroshihorie commented Nov 27, 2023

Hello @ronnyf !

This is a known issue which has been reported before : webrtc-sdk/webrtc#94

I want to fix this eventually but since we don't use this route at the moment the priority is not high.
Our WebRTC code is located here: https://github.com/webrtc-sdk/webrtc
It would be great if you could figure out a non-breaking way to fix this, I believe it isn't complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants