Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegated stake NaN display bug #236

Open
rickstaa opened this issue Dec 3, 2023 · 2 comments · Fixed by #237 · May be fixed by #242
Open

Delegated stake NaN display bug #236

rickstaa opened this issue Dec 3, 2023 · 2 comments · Fixed by #237 · May be fixed by #242

Comments

@rickstaa
Copy link
Member

rickstaa commented Dec 3, 2023 •
edited
Loading

Problem description

Upon closer inspection, I observed that the explorer displays NaN when an orchestrator has staked less than 1e-6 LPT (e.g. https://explorer.livepeer.org/accounts/0x0074780feff1fd0277fad6ccdb5a29908df6051f/orchestrating). After investigating, it appears that this issue stems from a bug in the numeral library, as documented in this GitHub issue: adamwdraper/Numeral-js#596.

Recommendation

Although this is not a big deal considering that the numeral-js library is currently unmaintained and the bug remains unresolved, I propose migrating to the actively maintained https://github.com/BenjaminVanRyseghem/numbro library. This alternative library has already addressed the bug mentioned, solving this issue and making the explorer more future-proof.

Extra info

image

image
@rickstaa rickstaa changed the title NaN stake Delegated stake NaN display bug Dec 3, 2023
@rickstaa rickstaa mentioned this issue Dec 3, 2023
Merged
rickstaa added a commit to rickstaa/explorer that referenced this issue Dec 3, 2023
@rickstaa
refactor: migrate numeral to numbro
ad5c1e7 
This commit depricates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the
[numbro](https://github.com/BenjaminVanRyseghem/numbro). This was done
to fix livepeer#236 and ensure the explorer is future proof.
rickstaa added a commit to rickstaa/explorer that referenced this issue Dec 3, 2023
@rickstaa
refactor: migrate numeral to numbro
bf31821 
This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the
[numbro](https://github.com/BenjaminVanRyseghem/numbro). This was done
to fix livepeer#236 and ensure the explorer is future-proof.
@rickstaa
Copy link
Member Author

rickstaa commented Dec 3, 2023

This bug will be fixed if #237 is merged.

rickstaa added a commit to rickstaa/explorer that referenced this issue Dec 3, 2023
@rickstaa
refactor: migrate numeral library to numbro
eabdd52 
This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the
[numbro](https://github.com/BenjaminVanRyseghem/numbro). This was done
to fix livepeer#236 and ensure the explorer is future-proof.
rickstaa added a commit to rickstaa/explorer that referenced this issue Dec 3, 2023
@rickstaa
refactor: migrate numeral library to numbro
2d6d770 
This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the [numbro](https://github.com/BenjaminVanRyseghem/numbro).
This was done to fix livepeer#236 and ensure the explorer is future-proof.
rickstaa added a commit to rickstaa/explorer that referenced this issue Dec 3, 2023
@rickstaa
refactor: migrate numeral library to numbro
97cd507 
This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the [numbro](https://github.com/BenjaminVanRyseghem/numbro).
This was done to fix livepeer#236 and ensure the explorer is future-proof.
rickstaa added a commit to rickstaa/explorer that referenced this issue Dec 3, 2023
@rickstaa
refactor: migrate numeral library to numbro
34f579b 
This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the [numbro](https://github.com/BenjaminVanRyseghem/numbro).
This was done to fix livepeer#236 and ensure the explorer is future-proof.
rickstaa added a commit to rickstaa/explorer that referenced this issue Dec 3, 2023
@rickstaa
refactor: migrate numeral library to numbro
039d3a2 
This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the [numbro](https://github.com/BenjaminVanRyseghem/numbro).
This was done to fix livepeer#236 and ensure the explorer is future-proof.
0xcadams added a commit that referenced this issue Dec 12, 2023
@rickstaa @0xcadams
refactor: migrate numeral to numbro (#237)
8b2c557 
* refactor: migrate numeral library to numbro

This commit deprecates the use of the unmaintained
[numeral-js](https://github.com/adamwdraper/Numeral-js) library and
replaces it with the [numbro](https://github.com/BenjaminVanRyseghem/numbro).
This was done to fix #236 and ensure the explorer is future-proof.

* fix: fix argument typo

Co-authored-by: Chase Adams <[email protected]>

---------

Co-authored-by: Chase Adams <[email protected]>
@rickstaa
Copy link
Member Author

@0xcadams Now that #237 has been reverted, maybe we can reopen this issue?

@rickstaa rickstaa linked a pull request Dec 12, 2023 that will close this issue
Draft
@rickstaa rickstaa reopened this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rickstaa