Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed safeMath #571

Merged
merged 2 commits into from
May 25, 2022
Merged

removed safeMath #571

merged 2 commits into from
May 25, 2022

Conversation

kautukkundan
Copy link
Contributor

@kautukkundan kautukkundan commented May 13, 2022

What does this pull request do? Explain your changes. (required)

Since we have updated the contracts to 0.8.9 which includes safe arithmetics, OZ's SafeMath library is no longer required.

Specific updates (required)

  • removed imports for SafeMath
  • updated contracts to use inbuilt arithmetic functions

How did you test each of these updates (required)

Does this pull request close any open issues?

closes #559

Checklist:

  • README and other documentation updated
  • All tests using yarn test pass

Copy link
Contributor

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RiccardoBiosas
Copy link
Contributor

LGTM as well

@kautukkundan kautukkundan changed the base branch from confluence to cf/next May 25, 2022 14:27
@kautukkundan kautukkundan merged commit 5e7fcf9 into cf/next May 25, 2022
@kautukkundan kautukkundan deleted the kk/safemath-removal branch May 25, 2022 14:36
@0xcadams 0xcadams mentioned this pull request Jul 28, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SafeMath from the protocol's dependencies
3 participants