-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck VOD tasks #1103
Comments
Last week we implemented alarms when this happens, so we should not be alerted by customers when this happens in the future. This is currently blocked by a decision about how best to fix this issue, pending some changes with recording and RabbitMQ. We should discuss this as a group with Victor as the decider. |
Oh I did not now that we had this already and created this as well: #1031 The one I created is for a specific fix that we have to make though, which is not blocked by any decision AFAIK.
@pglowacky I'm not sure if this is blocked by anything. Were you meaning to comment on this other issue instead? livepeer/task-runner#19 Also, what changes to RabbitMQ were you referring to? |
Hm! I think this was the intended issue, and my comments were based on some conversation we had. If it's not true, disregard! |
We currently have an alert for this so we have a rough idea for how often this is happening. |
Describe the bug
When requesting certain tasks in VOD API ie. Import, Transcode, the tasks may be stuck in a false
Waiting
state if the task was never actually queued to run. This could happen if the API was unable to access the tasks queues due to credentials etc.Expected behavior
Tasks which never made it into the task-runner queues should be put into a
Failed
state directly.Additional context
enqueueTask in the scheduler could fail, provide a failure callback that sets the task state to
Failed
https://github.com/livepeer/livepeer-com/blob/d3bd5c6e2d133436024b6df09592370a565d8e53/packages/api/src/task/scheduler.ts#L165
https://github.com/livepeer/livepeer-com/blob/d3bd5c6e2d133436024b6df09592370a565d8e53/packages/api/src/store/queue.ts#L224
The text was updated successfully, but these errors were encountered: