Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Better Icons #20

Open
vinayraghu opened this issue Jun 9, 2013 · 7 comments · May be fixed by #21
Open

[Feature Request] Better Icons #20

vinayraghu opened this issue Jun 9, 2013 · 7 comments · May be fixed by #21

Comments

@vinayraghu
Copy link

The difference between the enabled and disabled states on the chrome browser extension (which I use) is very subtle. It would help if we could make the circle inside bigger or add a dash of color. I have attached some screenshots below. I can submit a PR if one of these is okay-ed. I can also share the original source files/iterate on the Hex colors to be used in the icons.

  • Active/Enabled with just grey
    Active with just grey
  • Active/Enabled with color
    Active with color
  • Disabled with color
    Disabled With Color
  • Unavailable with color
    Unavailable with color
@davidlitmark
Copy link

Such a coincidence. I installed the chrome extension this week and couldn't tell if it was enabled or disabled just by looking at the icons. I figured some colors would do it and made a couple of changes to a fork of the icon repo. It differs a bit from your suggestions above since both my icons for the Active and Enabled states are green and the Unavailable state remains gray. I don't know the difference between the Active and Enabled states, perhaps one of them should be gray. I was just about create the pull request when I found your issue.

Comments and suggestions are welcome!

@davidlitmark davidlitmark linked a pull request Jun 10, 2013 that will close this issue
Open
@vinayraghu
Copy link
Author

Hey @davidlitmark that is cool! Yeah..Its very essential to know if the plugin is enabled or not.

I saw your icons, they look neat. What software did you use to draw them on?

Here's what I feel

  1. Circle colors need to be a very bright green/red
  2. Safari and Chrome share the same icons so you can submit your PR for both
  3. Active and enabled I assume are the same things

Once this is merged, we can set about doing something similar for Firefox as well.

Also, personally, I wish the circle in the center was bigger. It looks VERY small on my screen.

@davidlitmark
Copy link

Thanks @rvinay88. The icons are drawn using Photoshop, but all the credit should go to @pepelsbey. I just added some color.

  1. Great comment. I'll intensify the colors.
  2. Good to know. I thought they were a different size, but I'll check that before a PR anyways.
  3. Can anyone else please explain how/if the Active and Enabled state differs? @andreyvit, perhaps?

With more intense colors perhaps the size of the circle in the center is ok?

@davidlitmark
Copy link

@rvinay88 I just pushed a commit with much brighter green and red colors to my fork, if you'd like to take a look.

@vinayraghu
Copy link
Author

Hey @davidlitmark this is much better! Now to work on the firefox images 👍

@davidlitmark
Copy link

Glad you like it. I've updated the PR. If it's merged I'll fix the Safari and Firefox icons as well.

@vip9
Copy link

vip9 commented Jun 29, 2015

Got same problem here, in Chrome. I didn't even realize, that LiveReload is working (or not). Love to see green/gray icons. When the change will be merged and published in Store?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add color indicators to Chrome extension icons davidlitmark/livereload-extensions
3 participants
@vip9 @davidlitmark @vinayraghu