From 961b6a3e9984b3e6d9c65d66397a78cb9340ed3d Mon Sep 17 00:00:00 2001
From: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Date: Sun, 12 Jan 2025 03:30:13 +0100
Subject: [PATCH] Replace checked="checked" with checked

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
---
 resources/js/src/makegrid.ts                  |  2 +-
 resources/js/src/modules/functions.ts         |  2 +-
 resources/js/src/modules/indexes.ts           |  4 +--
 resources/js/src/table/change.ts              |  2 +-
 .../templates/create_tracking_version.twig    | 26 +++++++++----------
 .../database/multi_table_query/form.twig      |  4 +--
 .../encoding/kanji_encoding_form.twig         |  2 +-
 resources/templates/gis_data_editor_form.twig |  2 +-
 .../templates/preferences/manage/main.twig    |  4 +--
 .../server/status/monitor/index.twig          |  8 +++---
 resources/templates/view_create.twig          |  2 +-
 src/ConfigStorage/UserGroups.php              |  2 +-
 src/Export/Export.php                         |  2 +-
 src/InsertEdit.php                            |  2 +-
 src/Plugins.php                               |  2 +-
 tests/unit/ConfigStorage/UserGroupsTest.php   |  2 +-
 .../Table/ImportControllerTest.php            |  2 +-
 tests/unit/InsertEditTest.php                 |  2 +-
 tests/unit/Tracking/TrackingTest.php          |  2 +-
 19 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/resources/js/src/makegrid.ts b/resources/js/src/makegrid.ts
index 283280693f3f..ac1a67d5ad9d 100644
--- a/resources/js/src/makegrid.ts
+++ b/resources/js/src/makegrid.ts
@@ -1867,7 +1867,7 @@ const makeGrid = function (t, enableResize = undefined, enableReorder = undefine
                     var currHeader = $firstRowCols[i];
                     var listElmt = document.createElement('div');
                     $(listElmt).text($(currHeader).text())
-                        .prepend('<input type="checkbox" ' + (g.colVisib[i] ? 'checked="checked" ' : '') + '>');
+                        .prepend('<input type="checkbox" ' + (g.colVisib[i] ? 'checked ' : '') + '>');
 
                     $listDiv.append(listElmt);
                     // add event on click
diff --git a/resources/js/src/modules/functions.ts b/resources/js/src/modules/functions.ts
index fa116c6607d1..a5f29d2451ea 100644
--- a/resources/js/src/modules/functions.ts
+++ b/resources/js/src/modules/functions.ts
@@ -1049,7 +1049,7 @@ export function loadForeignKeyCheckbox () {
     $.get('index.php?route=/sql/get-default-fk-check-value', params, function (data) {
         var html = '<input type="hidden" name="fk_checks" value="0">' +
             '<input type="checkbox" name="fk_checks" id="fk_checks"' +
-            (data.default_fk_check_value ? ' checked="checked"' : '') + '>' +
+            (data.default_fk_check_value ? ' checked' : '') + '>' +
             '<label for="fk_checks">' + window.Messages.strForeignKeyCheck + '</label>';
         $('.load-default-fk-check-value').replaceWith(html);
     });
diff --git a/resources/js/src/modules/indexes.ts b/resources/js/src/modules/indexes.ts
index ae3694d36456..5e5f50cae3c4 100644
--- a/resources/js/src/modules/indexes.ts
+++ b/resources/js/src/modules/indexes.ts
@@ -258,7 +258,7 @@ function getCompositeIndexList (sourceArray, colIndex) {
         $compositeIndexList.append(
             '<li>' +
             '<input type="radio" name="composite_with" ' +
-            (alreadyPresent ? 'checked="checked"' : '') +
+            (alreadyPresent ? 'checked' : '') +
             ' id="composite_index_' + i + '" value="' + i + '">' +
             '<label for="composite_index_' + i + '">' + columnNames.join(', ') +
             '</label>' +
@@ -444,7 +444,7 @@ var removeIndexOnChangeEvent = function () {
  */
 function indexTypeSelectionDialog (sourceArray, indexChoice, colIndex): void {
     var $singleColumnRadio = $('<div class="form-check">' +
-        '<input class="form-check-input" type="radio" id="single_column" name="index_choice" checked="checked">' +
+        '<input class="form-check-input" type="radio" id="single_column" name="index_choice" checked>' +
         '<label class="form-check-label" for="single_column">' +
         window.Messages.strCreateSingleColumnIndex + '</label></div>');
     var $compositeIndexRadio = $('<div class="form-check">' +
diff --git a/resources/js/src/table/change.ts b/resources/js/src/table/change.ts
index 0812f38622fd..83cb9a754b6d 100644
--- a/resources/js/src/table/change.ts
+++ b/resources/js/src/table/change.ts
@@ -868,7 +868,7 @@ function addNewContinueInsertionFields (event) {
 
             // Insert/Clone the ignore checkboxes
             if (currRows === 1) {
-                $('<input id="insert_ignore_1" type="checkbox" name="insert_ignore_1" checked="checked">')
+                $('<input id="insert_ignore_1" type="checkbox" name="insert_ignore_1" checked>')
                     .insertBefore($('table.insertRowTable').last())
                     .after('<label for="insert_ignore_1">' + window.Messages.strIgnore + '</label>');
             } else {
diff --git a/resources/templates/create_tracking_version.twig b/resources/templates/create_tracking_version.twig
index d759d329943f..85505f346872 100644
--- a/resources/templates/create_tracking_version.twig
+++ b/resources/templates/create_tracking_version.twig
@@ -22,16 +22,16 @@
 
             {% if type == 'both' or type == 'table' %}
                 <input type="checkbox" name="alter_table" value="true"
-                    {{- 'ALTER TABLE' in default_statements ? ' checked="checked"' }}>
+                    {{- 'ALTER TABLE' in default_statements ? ' checked' }}>
                 ALTER TABLE<br>
                 <input type="checkbox" name="rename_table" value="true"
-                    {{- 'RENAME TABLE' in default_statements ? ' checked="checked"' }}>
+                    {{- 'RENAME TABLE' in default_statements ? ' checked' }}>
                 RENAME TABLE<br>
                 <input type="checkbox" name="create_table" value="true"
-                    {{- 'CREATE TABLE' in default_statements ? ' checked="checked"' }}>
+                    {{- 'CREATE TABLE' in default_statements ? ' checked' }}>
                 CREATE TABLE<br>
                 <input type="checkbox" name="drop_table" value="true"
-                    {{- 'DROP TABLE' in default_statements ? ' checked="checked"' }}>
+                    {{- 'DROP TABLE' in default_statements ? ' checked' }}>
                 DROP TABLE<br>
             {% endif %}
             {% if type == 'both' %}
@@ -39,36 +39,36 @@
             {% endif %}
             {% if type == 'both' or type == 'view' %}
                 <input type="checkbox" name="alter_view" value="true"
-                    {{- 'ALTER VIEW' in default_statements ? ' checked="checked"' }}>
+                    {{- 'ALTER VIEW' in default_statements ? ' checked' }}>
                 ALTER VIEW<br>
                 <input type="checkbox" name="create_view" value="true"
-                    {{- 'CREATE VIEW' in default_statements ? ' checked="checked"' }}>
+                    {{- 'CREATE VIEW' in default_statements ? ' checked' }}>
                 CREATE VIEW<br>
                 <input type="checkbox" name="drop_view" value="true"
-                    {{- 'DROP VIEW' in default_statements ? ' checked="checked"' }}>
+                    {{- 'DROP VIEW' in default_statements ? ' checked' }}>
                 DROP VIEW<br>
             {% endif %}
             <br>
 
             <input type="checkbox" name="create_index" value="true"
-                {{- 'CREATE INDEX' in default_statements ? ' checked="checked"' }}>
+                {{- 'CREATE INDEX' in default_statements ? ' checked' }}>
             CREATE INDEX<br>
             <input type="checkbox" name="drop_index" value="true"
-                {{- 'DROP INDEX' in default_statements ? ' checked="checked"' }}>
+                {{- 'DROP INDEX' in default_statements ? ' checked' }}>
             DROP INDEX<br>
 
             <p>{{ t('Track these data manipulation statements:') }}</p>
             <input type="checkbox" name="insert" value="true"
-                {{- 'INSERT' in default_statements ? ' checked="checked"' }}>
+                {{- 'INSERT' in default_statements ? ' checked' }}>
             INSERT<br>
             <input type="checkbox" name="update" value="true"
-                {{- 'UPDATE' in default_statements ? ' checked="checked"' }}>
+                {{- 'UPDATE' in default_statements ? ' checked' }}>
             UPDATE<br>
             <input type="checkbox" name="delete" value="true"
-                {{- 'DELETE' in default_statements ? ' checked="checked"' }}>
+                {{- 'DELETE' in default_statements ? ' checked' }}>
             DELETE<br>
             <input type="checkbox" name="truncate" value="true"
-                {{- 'TRUNCATE' in default_statements ? ' checked="checked"' }}>
+                {{- 'TRUNCATE' in default_statements ? ' checked' }}>
             TRUNCATE<br>
         </div>
 
diff --git a/resources/templates/database/multi_table_query/form.twig b/resources/templates/database/multi_table_query/form.twig
index 236ba327d3a7..4b6f809216e4 100644
--- a/resources/templates/database/multi_table_query/form.twig
+++ b/resources/templates/database/multi_table_query/form.twig
@@ -34,7 +34,7 @@
                     <option value="">{{ t('select column') }}</option>
                   </select>
                   <br>
-                  <input type="checkbox" checked="checked" class="show_col">
+                  <input type="checkbox" checked class="show_col">
                   <span>{{ t('Show') }}</span>
                   <br>
                   <input type="text" placeholder="{{ t('Table alias') }}" class="table_alias">
@@ -65,7 +65,7 @@
                                    name="logical_op[{{ id }}]"
                                    value="AND"
                                    class="logical_op"
-                                   checked="checked">
+                                   checked>
                             AND
                           </td>
                           <td>
diff --git a/resources/templates/encoding/kanji_encoding_form.twig b/resources/templates/encoding/kanji_encoding_form.twig
index 51495362724d..6f3182b2e0ac 100644
--- a/resources/templates/encoding/kanji_encoding_form.twig
+++ b/resources/templates/encoding/kanji_encoding_form.twig
@@ -1,6 +1,6 @@
 <ul>
     <li>
-        <input type="radio" name="knjenc" value="" checked="checked" id="kj-none">
+        <input type="radio" name="knjenc" value="" checked id="kj-none">
         <label for="kj-none">
           {{ t('None', context = 'None encoding conversion', notes = 'This is currently used only in Japanese locales') }}
         </label>
diff --git a/resources/templates/gis_data_editor_form.twig b/resources/templates/gis_data_editor_form.twig
index ac0994c5c429..030326322ac8 100644
--- a/resources/templates/gis_data_editor_form.twig
+++ b/resources/templates/gis_data_editor_form.twig
@@ -57,7 +57,7 @@
 
             <div class="card-footer">
               <div class="form-switch mt-1">
-                <input type="checkbox" id="useOsmAsBaseLayerSwitch" class="form-check-input" value="useBaseLayer"{{ srid != 0 ? ' checked="checked"' }}>
+                <input type="checkbox" id="useOsmAsBaseLayerSwitch" class="form-check-input" value="useBaseLayer"{{ srid != 0 ? ' checked' }}>
                 <label for="useOsmAsBaseLayerSwitch" id="useOsmAsBaseLayerSwitchLabel">{{ t('Use OpenStreetMaps as Base Layer') }}</label>
               </div>
             </div>
diff --git a/resources/templates/preferences/manage/main.twig b/resources/templates/preferences/manage/main.twig
index c384e3fce322..488691bb78bb 100644
--- a/resources/templates/preferences/manage/main.twig
+++ b/resources/templates/preferences/manage/main.twig
@@ -15,7 +15,7 @@
                   enctype="multipart/form-data">
                 {{ get_hidden_inputs() }}
                 <input type="hidden" name="json" value="">
-                <input type="radio" id="import_text_file" name="import_type" value="text_file" checked="checked">
+                <input type="radio" id="import_text_file" name="import_type" value="text_file" checked>
                 <label for="import_text_file"> {{ t('Import from file') }} </label>
                 <div id="opts_import_text_file" class="prefsmanage_opts">
                     <label for="input_import_file"> {{ t('Browse your computer:') }} </label>
@@ -75,7 +75,7 @@
                 {{ get_hidden_inputs() }}
                 <div>
                     <input type="radio" id="export_text_file" name="export_type"
-                           value="text_file" checked="checked">
+                           value="text_file" checked>
                     <label for="export_text_file">
                         {{ t('Save as JSON file') }}
                     </label><br>
diff --git a/resources/templates/server/status/monitor/index.twig b/resources/templates/server/status/monitor/index.twig
index db592f80d9d9..4b801b73c446 100644
--- a/resources/templates/server/status/monitor/index.twig
+++ b/resources/templates/server/status/monitor/index.twig
@@ -104,7 +104,7 @@
           <select name="presetCharts"></select>
           <br>
 
-          <input type="radio" name="chartType" value="variable" id="chartStatusVar" checked="checked">
+          <input type="radio" name="chartType" value="variable" id="chartStatusVar" checked>
           <label for="chartStatusVar">
             {{ t('Status variable(s)') }}
           </label>
@@ -137,7 +137,7 @@
             <input type="text" name="variableInput" id="variableInput">
             <br>
 
-            <input type="checkbox" name="differentialValue" id="differentialValue" value="differential" checked="checked">
+            <input type="checkbox" name="differentialValue" id="differentialValue" value="differential" checked>
             <label for="differentialValue">
               {{ t('Display as differential value') }}
             </label>
@@ -194,13 +194,13 @@
     <input type="text" name="dateEnd" class="datetimefield" value="">
   </p>
 
-  <input type="checkbox" id="limitTypes" value="1" checked="checked">
+  <input type="checkbox" id="limitTypes" value="1" checked>
   <label for="limitTypes">
     {{ t('Only retrieve SELECT,INSERT,UPDATE and DELETE Statements') }}
   </label>
   <br>
 
-  <input type="checkbox" id="removeVariables" value="1" checked="checked">
+  <input type="checkbox" id="removeVariables" value="1" checked>
   <label for="removeVariables">
     {{ t('Remove variable data in INSERT statements for better grouping') }}
   </label>
diff --git a/resources/templates/view_create.twig b/resources/templates/view_create.twig
index 7dd4e12e2b13..8e79905c6cdf 100644
--- a/resources/templates/view_create.twig
+++ b/resources/templates/view_create.twig
@@ -30,7 +30,7 @@
             <td class="text-nowrap"><label for="or_replace">OR REPLACE</label></td>
             <td>
               <input type="checkbox" name="view[or_replace]" id="or_replace"
-                {% if (view['or_replace']) %} checked="checked" {% endif %}
+                {% if (view['or_replace']) %} checked {% endif %}
                      value="1">
             </td>
           </tr>
diff --git a/src/ConfigStorage/UserGroups.php b/src/ConfigStorage/UserGroups.php
index 66a6d742fe57..c102f3ec0933 100644
--- a/src/ConfigStorage/UserGroups.php
+++ b/src/ConfigStorage/UserGroups.php
@@ -266,7 +266,7 @@ public static function getTabList(string $title, UserGroupLevel $level, array $s
         $tabDetails = [];
         foreach ($tabs as $tab => $tabName) {
             $tabDetail = [];
-            $tabDetail['in_array'] = in_array($tab, $selected) ? ' checked="checked"' : '';
+            $tabDetail['in_array'] = in_array($tab, $selected) ? ' checked' : '';
             $tabDetail['tab'] = $tab;
             $tabDetail['tab_name'] = $tabName;
             $tabDetails[] = $tabDetail;
diff --git a/src/Export/Export.php b/src/Export/Export.php
index 62f2435d67ab..d763e4e0bbd0 100644
--- a/src/Export/Export.php
+++ b/src/Export/Export.php
@@ -1028,7 +1028,7 @@ public function getMetadataTypes(): array
     public function getCheckedClause(string $key, array $array): string
     {
         if (in_array($key, $array)) {
-            return ' checked="checked"';
+            return ' checked';
         }
 
         return '';
diff --git a/src/InsertEdit.php b/src/InsertEdit.php
index 2cac2475b954..595e4ed6f7eb 100644
--- a/src/InsertEdit.php
+++ b/src/InsertEdit.php
@@ -1512,7 +1512,7 @@ public function getCommentsMap(string $db, string $table): array
     public function getHtmlForIgnoreOption(int $rowId, bool $checked = true): string
     {
         return '<input type="checkbox"'
-            . ($checked ? ' checked="checked"' : '')
+            . ($checked ? ' checked' : '')
             . ' name="insert_ignore_' . $rowId . '"'
             . ' id="insert_ignore_' . $rowId . '">'
             . '<label for="insert_ignore_' . $rowId . '">'
diff --git a/src/Plugins.php b/src/Plugins.php
index 0c73c743e5b7..4330140716a8 100644
--- a/src/Plugins.php
+++ b/src/Plugins.php
@@ -206,7 +206,7 @@ public static function checkboxCheck(string $section, string $opt): string
             && ((ImportSettings::$timeoutPassed && isset($_REQUEST[$opt]))
                 || ! empty(Config::getInstance()->settings[$section][$opt]))
         ) {
-            return ' checked="checked"';
+            return ' checked';
         }
 
         return '';
diff --git a/tests/unit/ConfigStorage/UserGroupsTest.php b/tests/unit/ConfigStorage/UserGroupsTest.php
index 75e456100e4b..f10ee42b57ba 100644
--- a/tests/unit/ConfigStorage/UserGroupsTest.php
+++ b/tests/unit/ConfigStorage/UserGroupsTest.php
@@ -147,7 +147,7 @@ public function testGetHtmlToEditUserGroup(): void
         self::assertStringContainsString('<input type="hidden" name="editUserGroupSubmit" value="1"', $html);
         self::assertStringContainsString(
             '<input class="form-check-input checkall" type="checkbox"'
-            . ' checked="checked" name="server_sql" id="server_sql" value="Y">',
+            . ' checked name="server_sql" id="server_sql" value="Y">',
             $html,
         );
         self::assertStringContainsString(
diff --git a/tests/unit/Controllers/Table/ImportControllerTest.php b/tests/unit/Controllers/Table/ImportControllerTest.php
index 72811e1406b3..406659b6e0f1 100644
--- a/tests/unit/Controllers/Table/ImportControllerTest.php
+++ b/tests/unit/Controllers/Table/ImportControllerTest.php
@@ -73,7 +73,7 @@ public function testImportController(): void
             'plugins_choice' => $choice,
             'options' => $options,
             'skip_queries_default' => '0',
-            'is_allow_interrupt_checked' => ' checked="checked"',
+            'is_allow_interrupt_checked' => ' checked',
             'local_import_file' => null,
             'is_upload' => true,
             'upload_dir' => '',
diff --git a/tests/unit/InsertEditTest.php b/tests/unit/InsertEditTest.php
index 06378d3e43b3..a36822186b20 100644
--- a/tests/unit/InsertEditTest.php
+++ b/tests/unit/InsertEditTest.php
@@ -2446,7 +2446,7 @@ public function testGetHtmlForIgnoreOption(): void
         $expected = '<input type="checkbox" %sname="insert_ignore_1"'
             . ' id="insert_ignore_1"><label for="insert_ignore_1">'
             . 'Ignore</label><br>' . "\n";
-        $checked = 'checked="checked" ';
+        $checked = 'checked ';
         self::assertSame(
             sprintf($expected, $checked),
             $this->insertEdit->getHtmlForIgnoreOption(1),
diff --git a/tests/unit/Tracking/TrackingTest.php b/tests/unit/Tracking/TrackingTest.php
index ec693a9d88d6..31aaa6813a9c 100644
--- a/tests/unit/Tracking/TrackingTest.php
+++ b/tests/unit/Tracking/TrackingTest.php
@@ -120,7 +120,7 @@ public function testGetHtmlForMain(): void
         );
         self::assertStringContainsString(
             '<input type="checkbox" name="delete" value="true"'
-                . ' checked="checked">' . "\n" . '            DELETE<br>',
+                . ' checked>' . "\n" . '            DELETE<br>',
             $html,
         );
         self::assertStringContainsString(__('Create version'), $html);