Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Bracket Pair Colorization Theme Compatibility #70

Open
JustinNusca opened this issue May 17, 2022 · 1 comment
Open

VSCode Bracket Pair Colorization Theme Compatibility #70

JustinNusca opened this issue May 17, 2022 · 1 comment

Comments

@JustinNusca
Copy link

JustinNusca commented May 17, 2022

As of VSCode 1.67, released in April 2022, the colorize bracket pairs option has been enabled by default.

This results in many bracket pairs using unexpected colors. In particular, some pairs may use colors that are too harsh and saturated compared to the rest of the colors in the theme's palette, and others may be too subtle and hard to differentiate from surrounding content.

For an example, see this comparison of the "Lilac" theme as displayed in the readme, and the appearance of the theme in VSCode with bracket pair colorization on:

Example Screenshot from ReadMe VSCode v1.67
Screen Shot 2022-05-17 at 9 45 14 AM

This occurs with all Noctis themes, and is now the default user experience, since bracket pair colorization is enabled by default. This can be worked around by turning the feature off.

I'm not familiar with building themes for VSCode, but is it possible to update the theme and/or locally modify my preferences, so that the colors used with this feature are more compatible with those used with the rest of the theme?

@JMayfield
Copy link

@JustinNusca you can update the bracket colors with whatever you like. Update your settings.json with something like this:

{
  "editor.bracketPairColorization.enabled": true,
  "workbench.colorCustomizations": {
    "editorBracketHighlight.foreground1": "#5caeef",
    "editorBracketHighlight.foreground2": "#dfb976",
    "editorBracketHighlight.foreground3": "#c172d9",
    "editorBracketHighlight.foreground4": "#4fb1bc",
    "editorBracketHighlight.foreground5": "#97c26c",
    "editorBracketHighlight.foreground6": "#abb2c0",
    "editorBracketHighlight.unexpectedBracket.foreground": "#db6165"
  },
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants