Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing pattern with same name overwrites the readme file #9

Open
jaknor opened this issue Oct 11, 2021 · 0 comments
Open

Sharing pattern with same name overwrites the readme file #9

jaknor opened this issue Oct 11, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@jaknor
Copy link
Contributor

jaknor commented Oct 11, 2021

Wasn't sure if I should file this as feature request or bug. If you share a pattern with the same name as an existing one it will overwrite whatever is there. This is useful as it allows you to update an existing pattern, however I don't think it should overwrite the README with an empty file.

Expected Behavior

The template.yaml should be updated, but the readme should not

Current Behavior

The readme file of the pattern is overwritten

Possible Solution

  • We could check if there is already a readme file and if there is skip creating it
  • We could prompt and ask if readme should be created
  • We could have a specific update command or update flag

Steps to Reproduce (for bugs)

  1. Share a pattern
  2. Update the README
  3. Make some updates to the pattern
  4. Share the pattern again using the same name

Environment

  • SAM Patterns CLI version:
  • Node version:
  • NPM version:
@jaknor jaknor added the bug Something isn't working label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant