Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using CSS per processor #37

Open
rukshn opened this issue Aug 10, 2021 · 3 comments
Open

Using CSS per processor #37

rukshn opened this issue Aug 10, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@rukshn
Copy link
Collaborator

rukshn commented Aug 10, 2021

Proposal for enhancement
I think we can have maintainable CSS and beneficial in the long run if we use a CSS pre processor to write style sheets instead of plain css.

We will be able to decouple css according to components like buttons, menu, typography etc, or utilities margins, padding etc.

And the pre processor will compile them into a single css file, expanded and minified.

We will be able to use the final compiled css file in the project.

This will lead to maintainable css codebase.

@rukshn rukshn added the enhancement New feature or request label Aug 10, 2021
@rukshn rukshn assigned buddhika75 and unassigned buddhika75 Aug 10, 2021
@buddhika75
Copy link
Member

Sure, we will do it.

@diniduhewage
Copy link
Contributor

I have a different opinion on this. PrimeFaces styling takes care of the page structuring and bootstrap adding icing to make pages more user-friendly. What we should do we should use the styling given by these two as much as possible. It will be easy to manage the styling if we use a minimum of other styling than those.

@rukshn
Copy link
Collaborator Author

rukshn commented Aug 11, 2021

Yes @diniduhewage i agree should try to use bootstrap and pf as much as possible

However, there are some style sheet files that are slowly growing. If it continues to grow won't it be difficult to maintain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants