Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolbar button for toggling Indent Guides #35

Open
lkcampbell opened this issue May 17, 2017 · 11 comments
Open

Add toolbar button for toggling Indent Guides #35

lkcampbell opened this issue May 17, 2017 · 11 comments
Assignees

Comments

@lkcampbell
Copy link
Owner

Add toolbar button for toggling Indent Guides

@lkcampbell lkcampbell self-assigned this May 17, 2017
@tweakimp
Copy link
Contributor

Do you need an icon for that?

@lkcampbell
Copy link
Owner Author

@tweakimp, not sure yet. I will let you know if I do, thanks.

@lkcampbell
Copy link
Owner Author

@tweakimp, what did you have in mind?

It has to look professional and match the Brackets toolbar style.

@lkcampbell
Copy link
Owner Author

@tweakimp send me a file or a screenshot.

@tweakimp
Copy link
Contributor

icon suggestion
I thought of something like this. The grey background is supposed to be the brackets background.
It has to be really simple so it still looks good in 24px*24px.
If you like it, I will rebuild it as an SVG.

@lkcampbell
Copy link
Owner Author

@tweakimp yes, that looks really good.

Can you set it up like the Markdown Preview SVG? With two different colored sprites in one SVG? That way I can reuse the code @gruehle wrote and I already know it looks good.

@lkcampbell
Copy link
Owner Author

@tweakimp
Copy link
Contributor

tweakimp commented May 30, 2017

@lkcampbell
Copy link
Owner Author

lkcampbell commented Jun 2, 2017

@tweakimp, I do like it, thank you very much for helping me.

The colors and size and format are perfect.

One question. Why did you change your design?

I feel that you first design was better. The one with the skinny rectangles. Why did you change them into squares?

Let me know, I always enjoy discussing design even if I am not very good at it :).

Lance.

@tweakimp
Copy link
Contributor

tweakimp commented Jun 3, 2017

I had to change the "code" lines and the indent guides to the same size so that they fit right into the 24*24 grid. Then the vertical rectangles looked just like the horizontal ones, so they became squares, which is closer to the actual guides anyway.

Maybe you like this one more :)
https://gist.github.com/tweakimp/3aae700878b3ee42736c915802a59f1c

@lkcampbell
Copy link
Owner Author

@tweakimp yes, I like that one better, thanks :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants