Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets indent guide appears with dashed lines instead of straight #36

Open
frankny opened this issue Jun 6, 2017 · 11 comments
Open
Assignees
Labels

Comments

@frankny
Copy link

frankny commented Jun 6, 2017

Any ideas how to fix this? Image attached displaying behavior. Thanks
e25039ce-49d8-11e7-87a2-b4cddb252ec5

@lkcampbell
Copy link
Owner

@frankny, I know @tweakimp has been looking at ways to dynamically size the guide segments for issue #34 but I haven't investigated his solution yet. Maybe he can tell us if it is applicable to this problem as well.

The only workaround I know of right now is to use different fonts or themes. The gaps are being caused by the extra space between the lines, probably a style of the theme.

@tweakimp
Copy link
Contributor

tweakimp commented Jun 7, 2017

Please tell us the theme and the settings fonts.fontSize and fonts.fontFamily you are using.
Maybe a theme could widen the space between lines while the font stays the same so that these gaps are created.

@frankny
Copy link
Author

frankny commented Jun 7, 2017

@lkcampbell @tweakimp Yes, depending on what themes I use the problem does go away. I'm using 'smart theme dark' and my font is 'Andale Mono'. I'm kind of a stickler for editor appearance and spent a decent amount of time getting it to look how I want, so changing the appearance so that the extension works wouldn't be an option for me. Either way, I appreciate the help!

@tweakimp
Copy link
Contributor

tweakimp commented Jun 7, 2017

In smart theme dark settings file theme.less you can set .CodeMirror, .CodeMirror-scroll { line-height: 15px; } which will fix the problem but obviously make each line height smaller.

@frankny
Copy link
Author

frankny commented Jun 7, 2017

@tweakimp thanks ill try it out.

@lkcampbell
Copy link
Owner

@tweakimp, thanks for your input.

@frankny, the Indent Guides extension is built on CodeMirror Overlay API. Unfortunately, I am limited by that API. It has constantly introduced problems with the overlap or spread of the indent guide segments, something I have struggled with for years.

Your request is reasonable, but it is beyond my ability to solve, so I am am going to close this bug as a Code Challenge. Maybe someday I will convince the creator of CodeMirror to create Native Indent Guides, but until that happens, this is the hack job you get from me :).

@frankny
Copy link
Author

frankny commented Jun 8, 2017

@lkcampbell no worries, thanks anyways.

@lkcampbell
Copy link
Owner

I have a couple of ideas on how to solve this problem, so I am reopening the issue to investigate.

@lkcampbell lkcampbell reopened this Jul 11, 2017
@netoper
Copy link

netoper commented Nov 21, 2017

problem solved ;)
no matter on the font size or line height.. i use line-height: 1.5px; on screenshot.

lk

thank you, you made my day :)

@Michael-Luxus
Copy link

waw, thank you!

@lkcampbell
Copy link
Owner

@netoper I know I used that border solution some time in the past and ran into problems. Unfortunately, it was so long ago that I can't remember what the problems were. At any rate, I will be glad to take a look at it again and see if it will solve the problem now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants