add make test-network command
#132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, when tests are run we use vcr fixtures for any external API requests that our test calls make. This is great! It lets us run our tests quickly and deterministically, without worrying about the slowness or availablity of external services. However, this means our tests can't alert us to external APIs changing. If an API changes, our vcr fixtures would continue to provide us with old API data, giving us false-positives that our plugins were working. `make test-network` lets us run the same tests but ignores the vcr fixtures. This means that tests will hit the external network. It uses an environment variable, set by the Makefile, to alert our test utils whether or not to use vcr for a given run. Closes llimllib#123
|
I'm still learning github's PR tool. It seems like if I want to do two requests (one which depends on the other), the GH way to do it is to make it one monolithic pull request with individual commits. I'll close this and upload a different PR with both commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, when tests are run we use vcr fixtures for any external API
requests that our test calls make. This is great! It lets us run our
tests quickly and deterministically, without worrying about the slowness
or availablity of external services.
However, this means our tests can't alert us to external APIs changing.
If an API changes, our vcr fixtures would continue to provide us with
old API data, giving us false-positives that our plugins were working.
make test-networklets us run the same tests but ignores the vcrfixtures. This means that tests will hit the external network. It uses
an environment variable, set by the Makefile, to alert our test utils
whether or not to use vcr for a given run.
Closes #123