-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limbo handles slackbot reminders twice #156
Comments
haha, doh! I guess my test wasn't accurate enough |
I think the fix is to force commands to be on the start of the line, that would make them not trigger when someone says something like:" just use !image command " For the slackbot, maybe pre-process the incoming message to parse and remove the "Reminder: " and add a flag isReminder in the event json. |
I bet that there's something in the slackbot message packet that we could cue off of, to know that a reminder is being set as opposed to being triggered |
Isn't it set to ignore slack it?
…On Sat, 24 Mar. 2018, 01:28 Bill Mill, ***@***.***> wrote:
haha, doh! I guess my test wasn't accurate enough
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#156 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGk_7fUTnT2rZFUsdmDoC-bUNhkuORFZks5thRSOgaJpZM4S45gV>
.
|
In the current implementation looks like it: https://github.com/llimllib/limbo/blob/master/limbo/limbo.py#L146 I'm running an older version on my bot, but I don't see a reason to filter out slackbot messages... |
!image cute dog
The text was updated successfully, but these errors were encountered: