Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limbo handles slackbot reminders twice #156

Open
llimllib opened this issue Mar 23, 2018 · 6 comments
Open

limbo handles slackbot reminders twice #156

llimllib opened this issue Mar 23, 2018 · 6 comments
Labels

Comments

@llimllib
Copy link
Owner

  1. Set a reminder for !image cute dog
  2. wait for the reminder to post
  3. note that limbo does not respond
@llimllib llimllib added the bug label Mar 23, 2018
@eSoares
Copy link
Contributor

eSoares commented Mar 23, 2018

To me, it's working.
But has a slightly different bug: it replies when I setup the reminder.

image

@llimllib
Copy link
Owner Author

haha, doh! I guess my test wasn't accurate enough

@llimllib llimllib changed the title limbo doesn't handle slackbot reminders limbo handles slackbot reminders twice Mar 23, 2018
@eSoares
Copy link
Contributor

eSoares commented Mar 23, 2018

I think the fix is to force commands to be on the start of the line, that would make them not trigger when someone says something like:" just use !image command "

For the slackbot, maybe pre-process the incoming message to parse and remove the "Reminder: " and add a flag isReminder in the event json.
That way would not break any plugins and solve the issue.

@llimllib
Copy link
Owner Author

I bet that there's something in the slackbot message packet that we could cue off of, to know that a reminder is being set as opposed to being triggered

@StewPoll
Copy link
Contributor

StewPoll commented Mar 23, 2018 via email

@eSoares
Copy link
Contributor

eSoares commented Mar 23, 2018

In the current implementation looks like it: https://github.com/llimllib/limbo/blob/master/limbo/limbo.py#L146

I'm running an older version on my bot, but I don't see a reason to filter out slackbot messages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants