Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Simple checkbox to exclude main prompt for inpaint #3116

Open
1 task done
Doa86 opened this issue Jun 7, 2024 · 2 comments
Open
1 task done

[Feature Request]: Simple checkbox to exclude main prompt for inpaint #3116

Doa86 opened this issue Jun 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Doa86
Copy link

Doa86 commented Jun 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

Right now with both improve detail and modify content inpaint options, the main positive prompt is always sent as well as the 'additional prompt'. This means that if I'm inpainting and the model can't see most of the image, it will attempt to redraw the entire prompt in the inpaint mask area.

Would be nice to have a simple little checkbox next to the additional prompt field to only send the additional prompt and exclude the main prompt. This means I don't have to do copy and paste gymnastics in order to only send the additional prompt for inpainting without losing my current main prompt (or needing to get it back from history later).

Proposed workflow

  1. Go to Inpaint -> Improve Detail / Modify Content.
  2. Fill in the desired additional prompt and hit the 'Exclude Main Prompt' checkbox.
  3. The model is only supplied with the additional prompt and not the main prompt for the inpaint procedure.

Additional information

No response

@Doa86 Doa86 added enhancement New feature or request triage This needs an (initial) review labels Jun 7, 2024
@Doa86 Doa86 changed the title [Feature Request]: Simple checkbox to exclude main positive prompt [Feature Request]: Simple checkbox to exclude main prompt for inpaint Jun 7, 2024
@mashb1t mashb1t removed the triage This needs an (initial) review label Jun 7, 2024
@Doa86
Copy link
Author

Doa86 commented Jun 8, 2024

This does beg the question as to how to deal with the style prompts and negative prompts with this option checked. Thinking about the use case, it's unlikely (though not impossible) someone would want to inpaint in a different style than they've selected for the rest of the image, so I would say it would make sense to still send the style prompts with the additional prompt.

Negative prompt is trickier, but I would lean towards still sending this as well, as there is no way to provide an 'additional negative prompt' and this has less impact on generations for SDXL.

@DavidDragonsage
Copy link
Contributor

I think this would be great feature, and I agree it should only apply to the main prompt, not the negative prompt.

As it is, I often wipe out the main prompt before Inpainting to avoid the often freaky results of having the main prompt partially regenerated in the Inpainting area. But since Inpainting is often the last step in creating an image, I end up with a log entry that says "beautiful hands" for example, and lose the valuable main prompt information from the log.

I always keep copies of the original image with its log also, but that may mean I have to go digging to find it, which can be time consuming.

So I am suggesting that if this enhancement is added, the log and the metadata should still keep of copy of the full main prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants