Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking compatibility should trigger a major version update #358

Open
Bryji opened this issue Feb 6, 2023 · 2 comments
Open

Breaking compatibility should trigger a major version update #358

Bryji opened this issue Feb 6, 2023 · 2 comments

Comments

@Bryji
Copy link

Bryji commented Feb 6, 2023

The 1.7.1 release were noted that:

WARNING: this version and above are not binary compatible with previous versions

I suggest that going by the semver rules, this should trigger a major release version change (2.0.0). Consider e.g. projects with multiple transitive dependencies to Enumeratum - these would all now need to be upgraded in sync, which would be unexpected for a point release (patch) update.

@lloydmeta
Copy link
Owner

Indeed, it should have but it was discovered after the release.

I'll keep this issue open since we don't have an issue for adding a checker for this but do have an open PR.

#315

Please feel free to contribute ^

@Bryji
Copy link
Author

Bryji commented Feb 7, 2023

Ah, I see. Thanks for the reply @lloydmeta

@lloydmeta lloydmeta reopened this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants