Try not to use-after-free

CodaFi · CodaFi · commit 180448dd2b14 · 2018-02-22T11:51:06.000-05:00
diff --git a/Sources/PrettyStackTrace/PrettyStackTrace.swift b/Sources/PrettyStackTrace/PrettyStackTrace.swift
@@ -154,8 +154,8 @@ private class PrettyStackTraceManager {
   func pop() {
     guard let stack = stack else { return }
     let prev = stack.pointee.prev
-    stack.deallocate(capacity: 1)
     free(stack.pointee.data)
+    stack.deallocate(capacity: 1)
     self.stack = prev
   }
 

Original file line number	Diff line number	Diff line change
`@@ -154,8 +154,8 @@ private class PrettyStackTraceManager {`
`154`	`154`	`func pop() {`
`155`	`155`	`guard let stack = stack else { return }`
`156`	`156`	`let prev = stack.pointee.prev`
`157`		`- stack.deallocate(capacity: 1)`
`158`	`157`	`free(stack.pointee.data)`
	`158`	`+ stack.deallocate(capacity: 1)`
`159`	`159`	`self.stack = prev`
`160`	`160`	`}`
`161`	`161`