From 1b48c6b9f0f2765d9ea54341641846d5879577ad Mon Sep 17 00:00:00 2001 From: Akshat Oke Date: Wed, 1 Jan 2025 08:51:35 +0000 Subject: [PATCH] AS: Rename to greedy, CFG obviation, comment fix --- llvm/include/llvm/CodeGen/MachineFunction.h | 2 +- llvm/include/llvm/Passes/MachinePassRegistry.def | 2 +- llvm/lib/CodeGen/RegAllocGreedy.cpp | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/llvm/include/llvm/CodeGen/MachineFunction.h b/llvm/include/llvm/CodeGen/MachineFunction.h index 662272e5e096180..41ff503d5329eb1 100644 --- a/llvm/include/llvm/CodeGen/MachineFunction.h +++ b/llvm/include/llvm/CodeGen/MachineFunction.h @@ -901,7 +901,7 @@ class LLVM_ABI MachineFunction { /// Run the current MachineFunction through the machine code verifier, useful /// for debugger use. - /// TODO: Add the param LiveStks + /// TODO: Add the param for LiveStacks analysis. /// \returns true if no problems were found. bool verify(LiveIntervals *LiveInts, SlotIndexes *Indexes, const char *Banner = nullptr, raw_ostream *OS = nullptr, diff --git a/llvm/include/llvm/Passes/MachinePassRegistry.def b/llvm/include/llvm/Passes/MachinePassRegistry.def index 5facdfa825e4cbf..fa7f769f31fddea 100644 --- a/llvm/include/llvm/Passes/MachinePassRegistry.def +++ b/llvm/include/llvm/Passes/MachinePassRegistry.def @@ -189,7 +189,7 @@ MACHINE_FUNCTION_PASS_WITH_PARAMS( "filter=reg-filter;no-clear-vregs") MACHINE_FUNCTION_PASS_WITH_PARAMS( - "regallocgreedy", "RAGreedyPass", + "greedy", "RAGreedyPass", [](RAGreedyPass::Options Opts) { return RAGreedyPass(Opts); }, [PB = this](StringRef Params) { // TODO: parseRegAllocGreedyFilterFunc(*PB, Params); diff --git a/llvm/lib/CodeGen/RegAllocGreedy.cpp b/llvm/lib/CodeGen/RegAllocGreedy.cpp index 2b5e5c5b168d207..e0969af048bacaa 100644 --- a/llvm/lib/CodeGen/RegAllocGreedy.cpp +++ b/llvm/lib/CodeGen/RegAllocGreedy.cpp @@ -242,8 +242,6 @@ PreservedAnalyses RAGreedyPass::run(MachineFunction &MF, PA.preserve(); PA.preserve(); PA.preserve(); - PA.preserve(); - PA.preserve(); PA.preserve(); PA.preserve(); return PA;