From 688acb13b1d1eb751c83466935ab12f2b8047930 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 22 Dec 2024 19:55:45 -0800 Subject: [PATCH] [MC] Clean up tests that depend on implicit .text in MCAsmStreamer AMDGPUTargetAsmStreamer::EmitDirectiveAMDGCNTarget called by onBeginOfFile emits .amdgcn_target, which will not be before .text when we change the .text parser to actually print .text . The current .text is from initSections. --- llvm/test/MC/AMDGPU/hsa-exp.s | 3 --- llvm/test/MC/AMDGPU/hsa-gfx12-v4.s | 1 - llvm/test/MC/AMDGPU/hsa-tg-split.s | 3 --- llvm/test/MC/AMDGPU/hsa-v4.s | 3 --- llvm/test/MC/AMDGPU/hsa-v5-uses-dynamic-stack.s | 3 --- llvm/test/MC/AMDGPU/user-sgpr-count.s | 3 --- 6 files changed, 16 deletions(-) diff --git a/llvm/test/MC/AMDGPU/hsa-exp.s b/llvm/test/MC/AMDGPU/hsa-exp.s index 2c8dd6f8eeb48..3cc35b781507b 100644 --- a/llvm/test/MC/AMDGPU/hsa-exp.s +++ b/llvm/test/MC/AMDGPU/hsa-exp.s @@ -13,9 +13,6 @@ // ELF: Section: .text // ELF: } -.text -// ASM: .text - .amdgcn_target "amdgcn-unknown-amdhsa--gfx700" // ASM: .amdgcn_target "amdgcn-unknown-amdhsa--gfx700" diff --git a/llvm/test/MC/AMDGPU/hsa-gfx12-v4.s b/llvm/test/MC/AMDGPU/hsa-gfx12-v4.s index 7b591904e877f..ea649bc76116a 100644 --- a/llvm/test/MC/AMDGPU/hsa-gfx12-v4.s +++ b/llvm/test/MC/AMDGPU/hsa-gfx12-v4.s @@ -47,7 +47,6 @@ // OBJDUMP-NEXT: 00f0 00000c60 80000000 00040000 00000000 .text -// ASM: .text .amdgcn_target "amdgcn-amd-amdhsa--gfx1200" // ASM: .amdgcn_target "amdgcn-amd-amdhsa--gfx1200" diff --git a/llvm/test/MC/AMDGPU/hsa-tg-split.s b/llvm/test/MC/AMDGPU/hsa-tg-split.s index 78235e7125810..ca3de214a64a0 100644 --- a/llvm/test/MC/AMDGPU/hsa-tg-split.s +++ b/llvm/test/MC/AMDGPU/hsa-tg-split.s @@ -8,9 +8,6 @@ // OBJDUMP-NEXT: 0020 00000000 00000000 00000000 00000100 // OBJDUMP-NEXT: 0030 0000ac00 80000000 00000000 00000000 -.text -// ASM: .text - .amdgcn_target "amdgcn-amd-amdhsa--gfx90a:xnack+" // ASM: .amdgcn_target "amdgcn-amd-amdhsa--gfx90a:xnack+" diff --git a/llvm/test/MC/AMDGPU/hsa-v4.s b/llvm/test/MC/AMDGPU/hsa-v4.s index 5aa7a58578dec..931b4e874630b 100644 --- a/llvm/test/MC/AMDGPU/hsa-v4.s +++ b/llvm/test/MC/AMDGPU/hsa-v4.s @@ -46,9 +46,6 @@ // OBJDUMP-NEXT: 00e0 00000000 00000000 00000000 00000000 // OBJDUMP-NEXT: 00f0 0000ac00 80000000 00000000 00000000 -.text -// ASM: .text - .amdgcn_target "amdgcn-amd-amdhsa--gfx904:xnack+" // ASM: .amdgcn_target "amdgcn-amd-amdhsa--gfx904:xnack+" diff --git a/llvm/test/MC/AMDGPU/hsa-v5-uses-dynamic-stack.s b/llvm/test/MC/AMDGPU/hsa-v5-uses-dynamic-stack.s index ec3d5bae22d17..b71d384b47613 100644 --- a/llvm/test/MC/AMDGPU/hsa-v5-uses-dynamic-stack.s +++ b/llvm/test/MC/AMDGPU/hsa-v5-uses-dynamic-stack.s @@ -51,9 +51,6 @@ // OBJDUMP-NEXT: 00e0 00000000 00000000 00000000 00000000 // OBJDUMP-NEXT: 00f0 0000ac00 80000000 00000000 00000000 -.text -// ASM: .text - .amdgcn_target "amdgcn-amd-amdhsa--gfx904:xnack+" // ASM: .amdgcn_target "amdgcn-amd-amdhsa--gfx904:xnack+" diff --git a/llvm/test/MC/AMDGPU/user-sgpr-count.s b/llvm/test/MC/AMDGPU/user-sgpr-count.s index 950c514f786b2..8a12741920dd4 100644 --- a/llvm/test/MC/AMDGPU/user-sgpr-count.s +++ b/llvm/test/MC/AMDGPU/user-sgpr-count.s @@ -1,8 +1,5 @@ // RUN: llvm-mc -triple amdgcn-amd-amdhsa -mcpu=gfx90a --amdhsa-code-object-version=4 -mattr=+xnack < %s | FileCheck --check-prefix=ASM %s -.text -// ASM: .text - .amdgcn_target "amdgcn-amd-amdhsa--gfx90a:xnack+" // ASM: .amdgcn_target "amdgcn-amd-amdhsa--gfx90a:xnack+"