From cfde4fbccf5d8d949a8cade0a4f8ef9b0f47ca73 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 25 Oct 2024 16:46:38 -0400 Subject: [PATCH] [libc++] Remove obsolete Solaris and Newlib support for locales (#113721) The solaris header file doesn't even exist, so that's definitely dead code. The newlib header is empty, which means that localization can't work on that platform. If someone is using libc++ with Newlib, they must be providing LIBCXX_HAS_NO_LOCALIZATION today for anything to work, so that header is basically dead code as well. --- libcxx/include/CMakeLists.txt | 1 - libcxx/include/__locale_dir/locale_base_api.h | 4 ---- libcxx/include/__locale_dir/locale_base_api/newlib.h | 12 ------------ libcxx/include/module.modulemap | 1 - 4 files changed, 18 deletions(-) delete mode 100644 libcxx/include/__locale_dir/locale_base_api/newlib.h diff --git a/libcxx/include/CMakeLists.txt b/libcxx/include/CMakeLists.txt index 63aa74e09bb1a27..506ed721d0843ec 100644 --- a/libcxx/include/CMakeLists.txt +++ b/libcxx/include/CMakeLists.txt @@ -497,7 +497,6 @@ set(files __locale_dir/locale_base_api/fuchsia.h __locale_dir/locale_base_api/ibm.h __locale_dir/locale_base_api/musl.h - __locale_dir/locale_base_api/newlib.h __locale_dir/locale_base_api/openbsd.h __locale_dir/locale_base_api/win32.h __locale_dir/locale_guard.h diff --git a/libcxx/include/__locale_dir/locale_base_api.h b/libcxx/include/__locale_dir/locale_base_api.h index 8c000c558c52793..eab7fa8bf62faec 100644 --- a/libcxx/include/__locale_dir/locale_base_api.h +++ b/libcxx/include/__locale_dir/locale_base_api.h @@ -15,10 +15,6 @@ # include <__locale_dir/locale_base_api/ibm.h> #elif defined(__ANDROID__) # include <__locale_dir/locale_base_api/android.h> -#elif defined(__sun__) -# include <__locale_dir/locale_base_api/solaris.h> -#elif defined(_NEWLIB_VERSION) -# include <__locale_dir/locale_base_api/newlib.h> #elif defined(__OpenBSD__) # include <__locale_dir/locale_base_api/openbsd.h> #elif defined(__Fuchsia__) diff --git a/libcxx/include/__locale_dir/locale_base_api/newlib.h b/libcxx/include/__locale_dir/locale_base_api/newlib.h deleted file mode 100644 index 7da10e5889843dd..000000000000000 --- a/libcxx/include/__locale_dir/locale_base_api/newlib.h +++ /dev/null @@ -1,12 +0,0 @@ -//===----------------------------------------------------------------------===// -// -// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. -// See https://llvm.org/LICENSE.txt for license information. -// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception -// -//===----------------------------------------------------------------------===// - -#ifndef _LIBCPP___LOCALE_DIR_LOCALE_BASE_API_NEWLIB_H -#define _LIBCPP___LOCALE_DIR_LOCALE_BASE_API_NEWLIB_H - -#endif // _LIBCPP___LOCALE_DIR_LOCALE_BASE_API_NEWLIB_H diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap index c79070c318759db..f92e8bf5fc9aba5 100644 --- a/libcxx/include/module.modulemap +++ b/libcxx/include/module.modulemap @@ -1451,7 +1451,6 @@ module std [system] { textual header "__locale_dir/locale_base_api/fuchsia.h" textual header "__locale_dir/locale_base_api/ibm.h" textual header "__locale_dir/locale_base_api/musl.h" - textual header "__locale_dir/locale_base_api/newlib.h" textual header "__locale_dir/locale_base_api/openbsd.h" textual header "__locale_dir/locale_base_api/win32.h" }