Disable TORCH_MLIR_ENABLE_JIT_IR_IMPORTER by default

- Only enable it in CI for update_abstract_interp_lib.sh and update_torch_ods.sh usage.

CMakeLists.txt

@@ -48,8 +48,14 @@ option(TORCH_MLIR_OUT_OF_TREE_BUILD "Specifies an out of tree build" OFF)
 
 # PyTorch native extension gate. If OFF, then no features which depend on
 # native extensions will be built.
+# TORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS will be disabled by default shortly,
+# once some reorganizations of the testing codebase makes that possible.
 option(TORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS "Enables PyTorch native extension features" ON)
-cmake_dependent_option(TORCH_MLIR_ENABLE_JIT_IR_IMPORTER "Enables JIT IR Importer" ON TORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS OFF)
+# NOTE: The JIT_IR_IMPORTER paths have become unsupportable due to age and lack of maintainers.
+# Turning this off disables the old TorchScript path, leaving FX based import as the current supported option.
+# The option will be retained for a time, and if a maintainer is interested in setting up testing for it,
+# please reach out on the list and speak up for it. It will only be enabled in CI for test usage.
+cmake_dependent_option(TORCH_MLIR_ENABLE_JIT_IR_IMPORTER "Enables JIT IR Importer" OFF TORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS OFF)
 cmake_dependent_option(TORCH_MLIR_ENABLE_LTC "Enables LTC backend" OFF TORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS OFF)
 
 option(TORCH_MLIR_ENABLE_ONNX_C_IMPORTER "Enables the ONNX C importer" OFF)

build_tools/ci/build_posix.sh

@@ -50,7 +50,8 @@ cmake -S "$repo_root/externals/llvm-project/llvm" -B "$build_dir" \
   -DLLVM_EXTERNAL_TORCH_MLIR_SOURCE_DIR="$repo_root" \
   -DLLVM_TARGETS_TO_BUILD=host \
   -DMLIR_ENABLE_BINDINGS_PYTHON=ON \
-  -DTORCH_MLIR_ENABLE_LTC=ON
+  -DTORCH_MLIR_ENABLE_LTC=ON \
+  -DTORCH_MLIR_ENABLE_JIT_IR_IMPORTER=ON
 echo "::endgroup::"
 
 echo "::group::Build"

build_tools/ci/test_posix.sh

@@ -8,22 +8,6 @@ torch_version="${1:-unknown}"
 
 export PYTHONPATH="$repo_root/build/tools/torch-mlir/python_packages/torch_mlir:$repo_root/projects/pt1"
 
-echo "::group::Run Linalg e2e integration tests"
-python -m e2e_testing.main --config=linalg -v
-echo "::endgroup::"
-
-echo "::group::Run make_fx + TOSA e2e integration tests"
-python -m e2e_testing.main --config=make_fx_tosa -v
-echo "::endgroup::"
-
-echo "::group::Run TOSA e2e integration tests"
-python -m e2e_testing.main --config=tosa -v
-echo "::endgroup::"
-
-echo "::group::Run Stablehlo e2e integration tests"
-python -m e2e_testing.main --config=stablehlo -v
-echo "::endgroup::"
-
 echo "::group::Run ONNX e2e integration tests"
 python -m e2e_testing.main --config=onnx -v
 echo "::endgroup::"

build_tools/update_abstract_interp_lib.sh

@@ -41,6 +41,9 @@ if [ ! -z ${TORCH_MLIR_EXT_MODULES} ]; then
   ext_module="${TORCH_MLIR_EXT_MODULES} "
 fi
 
+# To enable this python package, manually build torch_mlir with:
+#   -DTORCH_MLIR_ENABLE_JIT_IR_IMPORTER=ON
+# TODO: move this package out of JIT_IR_IMPORTER.
 PYTHONPATH="${pypath}" python \
   -m torch_mlir.jit_ir_importer.build_tools.abstract_interp_lib_gen \
   --pytorch_op_extensions=${ext_module:-""} \

build_tools/update_torch_ods.sh

@@ -42,6 +42,9 @@ if [ ! -z ${TORCH_MLIR_EXT_MODULES} ]; then
 fi
 
 set +u
+# To enable this python package, manually build torch_mlir with:
+#   -DTORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS=ON
+# TODO: move this package out of JIT_IR_IMPORTER.
 PYTHONPATH="${PYTHONPATH}:${pypath}" python \
   -m torch_mlir.jit_ir_importer.build_tools.torch_ods_gen \
   --torch_ir_include_dir="${torch_ir_include_dir}" \

docs/add_ops.md

@@ -38,7 +38,8 @@ PS: IREE is pronounced Eerie, and hence the ghost icon.
 
 ### How to TorchToLinalg
 
-You will need to do 4 things:
+You will need to do 5 things:
+- make sure -DTORCH_MLIR_ENABLE_JIT_IR_IMPORTER=ON is added during build. This is to enable the python file used in `build_tools/update_torch_ods.sh` and `build_tools/update_abstract_interp_lib.sh`
 - make sure the op exists in `torch_ods_gen.py`, and then run `build_tools/update_torch_ods.sh`, and then build. This generates `GeneratedTorchOps.td`, which is used to generate the cpp and h files where ops function signatures are defined.
     - Reference [torch op registry](https://github.com/pytorch/pytorch/blob/7451dd058564b5398af79bfc1e2669d75f9ecfa2/torch/csrc/jit/passes/utils/op_registry.cpp#L21)
 - make sure the op exists in `abstract_interp_lib_gen.py`, and then run `build_tools/update_abstract_interp_lib.sh`, and then build. This generates `AbstractInterpLib.cpp`, which is used to generate the cpp and h files where ops function signatures are defined.