-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "favorite" button to traces #173
Comments
Hey @skull8888888 is this issue only related to the UX, meaning that the rest of the functionality is already implemented in the backend or does this also needs to be done with this issue? |
@patricksolka the entire thing needs to be implemented, but I'm happy to make a DB design and API routes and collaborate on this issue together. Did you want to add the UI? |
@skull8888888 Yes, I'd love to work on the UI and contribute to this repo! |
@patricksolka awesome, you can go ahead and start with frontend, just add star icon from lucide-icons as another column and add "add" and "remove" functions placeholders. |
Hey @skull8888888, I followed the steps in Contributing.md to get the frontend up and running. The DB connection seems fine, but I'm getting this error:
Just to mention, I haven't made an changes to the .env yet. Could you help me out with this? Best wishes! ✌🏻 |
Hey @patricksolka sorry about this. Yeah, there were a couple problems with migrations, as we had to edit some of them manually when resolving conflicts. I did merge a change earlier today that should have removed this issue. Could you please try and sync the latest |
Hey @skull8888888 just wanted to check in and ask if there's a way to insert test data for traces without using an LLM to test the feature with the favorites. I've manually added some test data to the database, but I'm having trouble getting it to work. |
@patricksolka yes, you can use from lmnr import Laminar, observe
import time
# Laminar.initialize(...)
@observe
def foo(greeting: str = "Hello"):
time.sleep(1)
return f"{greeting} world"
foo() or import { Laminar, observe} from '@lmnr-ai/lmnr'
// Laminar.intialize(...)
const foo = async (greeting: string) => `${greeting} world`;
observe(
{ name: 'foo' },
foo,
'Hello'
)
.then((out) => {
console.log(out);
Laminar.shutdown();
}) |
Hey @skull8888888 just pushed a PR |
@patricksolka awesome! Will look deeper into during the weekend, from first glance looks good. |
@skull8888888 yeah sure, just let me know if there's something you want me to change! |
Add star icon to the trace row to mark this trace as favorite. Similar to how to can "star" emails in the gmail client.
The text was updated successfully, but these errors were encountered: