Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to select which columns to display #79

Open
dinmukhamedm opened this issue Oct 24, 2024 · 8 comments
Open

Add ability to select which columns to display #79

dinmukhamedm opened this issue Oct 24, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request frontend Requires work in the frontend package good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dinmukhamedm
Copy link
Member

We need to allow users to selectively show/hide columns in the pages with tables. The minimal requirement is for traces/spans/sessions tables.

One UX we could create is a dialog with a checklist of enabled columns, somewhat similar to what you can find in many AWS interfaces.

Screenshot 2024-10-23 at 22 51 13
(We won't need search though, we don't have that many columns).

Requirements and pointers:

  • The preference must be stored in localStorage.
  • The component must be in components/ui
    • Similar components are DatatableFilter and TextSearchFilter. The difference is that their source of truth is URL search params, whereas here we look for local storage.
  • Quite obviously, the component must be reusable, i.e. no reliance on hard-coded column names and/or definitions
@dinmukhamedm dinmukhamedm added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed frontend Requires work in the frontend package labels Oct 24, 2024
@shravya-chepa
Copy link

Hello, can I work on this?

@skull8888888
Copy link
Collaborator

@shravya-chepa absolutely, go for it!

@dinmukhamedm
Copy link
Member Author

@shravya-chepa just letting you know, we've updated the contributing guidelines with a new docker compose setup for people who only change frontend code. This should make the experience vastly easier. Refer to CONTRIBUTING.

@shravya-chepa
Copy link

Got it, thank you!

@sarthakvijayvargiya
Copy link
Contributor

Hey @shravya-chepa Are you working on this?

@shravya-chepa
Copy link

Hey, yes

@skull8888888
Copy link
Collaborator

@shravya-chepa that great, do you have a draft pr by any chance? Mb you can work together on it if you are busy?

@shravya-chepa
Copy link

shravya-chepa commented Nov 15, 2024

I wasn't able to recreate a trace from a sample web application and got stuck. On second thought, I think @sarthakvijayvargiya should work on this. I might not be able to continue working on this because of my other engagements. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Requires work in the frontend package good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants