Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub is not scrubbing #2

Closed
arbadacarbaYK opened this issue Mar 2, 2023 · 12 comments
Closed

Scrub is not scrubbing #2

arbadacarbaYK opened this issue Mar 2, 2023 · 12 comments
Assignees

Comments

@arbadacarbaYK
Copy link

arbadacarbaYK commented Mar 2, 2023

Testing scrub on legend after a few remarks about trouble with it in the LNbits TG group.

Originally wanted to send via split to a wallet and do a scrub from there to a lnaddress (lntipbot), which didnt work. neither to a LNURLp on the same or another instance.

Also tested direct payments to the Scrub-Wallet as well by paying an invoice - also no scrub.

@dergigi
Copy link

dergigi commented Mar 2, 2023

Can confirm. Not working for me on legends, also not working on my own instance (lnbits commit c81d3e06c8c4217c1c38a71e24964df0e7b80d2c).

@dni dni self-assigned this Mar 4, 2023
@dni
Copy link
Member

dni commented Mar 6, 2023

ok, scrubbing works in fakewallet locally for me, it maybe related the a issue that pops up with core lightning right now. lnbits/lnbits#1565

@dergigi
Copy link

dergigi commented Mar 11, 2023

It works sometimes and sometimes it doesn't, not sure why or how to best debug this. The wallets are well funded, so a lack of funds to pay fees is not it.

I thought it had something to do with multi-path payments, but that was also not it, as both MP and AMP work sometimes. But sometimes, scrubbing fails. Hmm 🤔

@xannythepleb
Copy link

+1 here it doesn't work for me either. Using LNTipBot as the backend so I don't think it's an LND issue (iirc, LNTips uses LNBits as a backend itself).

@ulrichard
Copy link

Doesn't work at all for me.
lnbits instance on https://timecatcher.lnbits.de
scrub target on https://card.swiss-bitcoin-pay.ch/

@talvasconcelos
Copy link
Collaborator

Can this be related to Lightning Network routing issues?

@ulrichard
Copy link

Manually sending to the same destination always works, so it's unlikely to be network routing related.

@arbadacarbaYK
Copy link
Author

Doesn't work at all for me. lnbits instance on https://timecatcher.lnbits.de scrub target on https://card.swiss-bitcoin-pay.ch/

You have to make sure that theres smth left over for the fees e.g. by adding satsto the wallet before the first scrub is defined.

Bildschirmfoto 2023-08-30 um 18 28 03

@MichaelAntonFischer
Copy link

Related to this issue on split, a periodic rerun would be great:
lnbits/splitpayments#10

@dni
Copy link
Member

dni commented Sep 20, 2023

i noted this for splits aswell.
maybe a scrub log, with all scrubs would make the failing scrubs more comprehensible and there could be a feature to manually rerun them

@MichaelAntonFischer
Copy link

As mentioned on Splits, for me an optional setting to periodically rescrub the wallet-balance sub fee reserve is the way to go.

the whole point about split and scrub is that it’s automatic. Right now I need to periodically send Sats to a different wallet and back again manually to retrigger.

@ulrichard
Copy link

It miraculously started working two weeks ago. I assume the operator of timecatcher.lnbits.de updated something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants