Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Make secret handling safer with secrecy #143

Open
dunxen opened this issue Jul 22, 2024 · 0 comments
Open

Task: Make secret handling safer with secrecy #143

dunxen opened this issue Jul 22, 2024 · 0 comments

Comments

@dunxen
Copy link
Collaborator

dunxen commented Jul 22, 2024

Description

We probably would want the secrecy crate or similar in future to make sensitive values Secret<String>s to reduce the chance of them being logged and only .expose() them where necessary. It also securely wipes it from memory when it's dropped.

Unfortunately, although grpc request headers values can be marked as sensitive (e.g. the macroon header), this doesn't actually do anything nifty like redaction in logging or secure wiping. We probably still want to mark them and then try to manually do something about them.

Steps to Complete

  1. Introduce secrecy crate and wrap sensitive values in Secret<T>, .expose()ing them where necessary.

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant