Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

"Needs Description" check should ignore decription templates #76

Open
gbenatt92 opened this issue Dec 27, 2019 · 0 comments
Open

"Needs Description" check should ignore decription templates #76

gbenatt92 opened this issue Dec 27, 2019 · 0 comments

Comments

@gbenatt92
Copy link

Proposal:

Modify the check for description at https://github.com/loadsmart/peril-settings/blob/master/rules/common/needsDescription.ts to consider our pre-made PR description templates as if it was empty.

Reasoning

A lot of people forget to fill the templates and send PRs for review without the proper information. Unfortunately, having the template means the check for description will always pass.

Exceptions:

We shouldn't try to apply it over all templates, but at least the one in Alice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant