Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when a Config value is not a string and is an object or something else #1

Open
justinyost opened this issue Jan 16, 2015 · 3 comments
Assignees
Labels

Comments

@justinyost
Copy link
Contributor

Screenshot included.

Examples of when this occurs is the Error handlers, with this command:

./bin/cake config_read.config_read Error

screen shot 2015-01-16 at 3 45 36 pm

@beporter
Copy link
Contributor

It's worth mentioning that if an object doesn't define a __toString() method, there's very little we can do about this except detect that and skip the entry maybe?

I may have also neglected to force the casting to string though.

@beporter
Copy link
Contributor

beporter commented Feb 3, 2015

@jtyost2 Might I recommend we fix this and #2 in the 2.x branch before we split the codebase off for Cake 3?

@beporter beporter assigned justinyost and unassigned beporter Feb 3, 2015
@beporter
Copy link
Contributor

beporter commented Feb 3, 2015

Can probably just change this line:

$val = escapeshellarg($val);

$val = escapeshellarg((string)$val);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants