Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Mayo Clinic when used as a workshed, is swapped directly after the Asdon Martin Buff after Diet has already completed #2099

Open
Tapionator opened this issue Sep 13, 2024 · 2 comments
Labels

Comments

@Tapionator
Copy link

When used with Asdon the Mayo Clinic was swapped in (to replace the Asdon) after the Full Diet was completed rendering it as not very useful unless manually using the workshed prior to starting garbo. See attached log for more information.

Command: Garbo workshed="Portable Mayo Clinic

Session Log attached.
Tapion Log - Mayo Swap Issue.txt

@Tapionator Tapionator changed the title [FEATURE] May Clinic when used as a workshed, is swapped directly after the Asdon Martin Buff [FEATURE] May Clinic when used as a workshed, is swapped directly after the Asdon Martin Buff rather than after Diet has already completed Sep 13, 2024
@Tapionator Tapionator changed the title [FEATURE] May Clinic when used as a workshed, is swapped directly after the Asdon Martin Buff rather than after Diet has already completed [FEATURE] Mayo Clinic when used as a workshed, is swapped directly after the Asdon Martin Buff rather than after Diet has already completed Sep 13, 2024
@horrible-little-slime
Copy link
Contributor

At its core, what we need to do to accomplish this is to specifically pre-cast asdon buffs before calculating diet. Ideally, what we'd do is:

  • calculate diet as though we had mayo up
  • make a turn estimate for tomorrow that again assumes mayo (don't think we currently have a complex system for estimating turns, which is fine)
  • precast asdon buffs
  • swap to mayo
  • actually execute diet

@Tapionator
Copy link
Author

Sounds perfect to me. If it's not possible or would royally mess up the script it's not the end of the world. I can always just continue manually using my asdon and swapping to the mayo after obtaining the buffs prior to running garbo.

@Tapionator Tapionator changed the title [FEATURE] Mayo Clinic when used as a workshed, is swapped directly after the Asdon Martin Buff rather than after Diet has already completed [FEATURE] Mayo Clinic when used as a workshed, is swapped directly after the Asdon Martin Buff after Diet has already completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants