-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for npm version
#35
Comments
Thanks for submitting an issue before the PR, we appreciate that! I'm not sure I follow what you mean by "supporting |
As you know, npm provides a built in manner for managing version bumps. As with most script support it also provides hooks throughout the various stages of running a script (e.g. pre, post, etc.). In the case of
During these stages npm also exposes variables to the script through name-spaced globals. A few have particular interest to
Using To maintain current formatting support in the output from Then the
Thoughts? |
Bump. @robinjoseph08 If this is out of scope for your intention for this module just let me know. |
Hey @JasonCust, sorry for the delay here. Your explanation makes sense, and I think that would be a pretty cool feature to implement. Some considerations:
If you'd like to put up a PR, we'd welcome it! |
@robinjoseph08 I think I came up with a good solution to support |
Bump. @robinjoseph08, let me know if this does or doesn't work for you. |
Am finding that I'd like to use |
Before submitting a PR, what are your thoughts for supporting
npm version
. This would have the benefit of working directly within existing npm scripting flows. Also this module could then leverage the npm variables exposed for getting/updating the version which would allow for support of various types of releases beyond major, minor, and patch.The main concern I can see is supporting workflows for generating a change log outside of versioning... although that doesn't seem like a normal use case.
The text was updated successfully, but these errors were encountered: